Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp6200756pxu; Wed, 23 Dec 2020 17:07:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJxfI+0PXxepQYDTsJOhJAFWtJfnIrl8bUehbsZi/gJ3Tr1By/tsy1ppR5D78T4f8d/dx0F0 X-Received: by 2002:a17:906:59a:: with SMTP id 26mr25782647ejn.309.1608772045945; Wed, 23 Dec 2020 17:07:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608772045; cv=none; d=google.com; s=arc-20160816; b=fn4r/BzLL5L6uLyZ503voF6t7wFkWx0VCSC9CFiUIlpBMVtbH+rKjZCz3V4/k5hiPD aB0BOZOzDXc0AXxWcYhfbGOOvnyXD4XYZPwCMV8ST1SVbGl0lptoaExg9QTfZFbh1gX2 3lQ1Reaon+C29nZVz2OBruldmjLGj7RxdnDppR0ekpZMaq8rTbNQgel4XoEY66AvmPKC 5JoQnlsFYp6sbXoe0q40bdBWbs01rUvd/SOTj74AfzLUnqULzynCsRNhy6pevC7fpmN4 Ej/r3c1LVogu9oHmK+SD6ah0Rz6GqY5AUS+ddHikb/UonENese1VTfUfkJw5NvF8hs+M EFYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:references:in-reply-to:subject:cc:to:from :dkim-signature; bh=CL3AnHOz06mrGbhgw6tM4Noc2JcCqYwI4iu0BsEovkk=; b=RAi21D7b8ysUpJCDioISF12Z1m9Xkz8ZQvZ/Fp3hlUZG27O6AMQXu5Diky0P6sPmoO srnsMlyr5Rjc3hc568fDd6DiXamfZn2KBf3j7cBR89kkRvVH04VgGazqbnZ3t3CRy7iW x6QiTc4R5Nqpa63ZtyPTMyQc4KRpUAA0YNJQxfFxOGGW+rntnllkM7hdrvdR5hKEQuYn iOg1N9c90eGjMmlRbosLYAQY41M7faFU5tVXV2c/tvym3lGzkuEhQL3pqpEjxMseW66L D13CdobgRiALZDoPHhjneU2rwiMbUXkuLpPkoeOqb/oA/hgnP1fIe6otCfSZ2cK4PMeA GOKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ellerman.id.au header.s=201909 header.b=fCiucknv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p20si14383206eds.141.2020.12.23.17.07.04; Wed, 23 Dec 2020 17:07:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ellerman.id.au header.s=201909 header.b=fCiucknv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728320AbgLXBGb (ORCPT + 99 others); Wed, 23 Dec 2020 20:06:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728065AbgLXBGb (ORCPT ); Wed, 23 Dec 2020 20:06:31 -0500 Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5539C061794 for ; Wed, 23 Dec 2020 17:05:50 -0800 (PST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4D1X2320TZz9sWX; Thu, 24 Dec 2020 12:05:47 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1608771947; bh=CL3AnHOz06mrGbhgw6tM4Noc2JcCqYwI4iu0BsEovkk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=fCiucknv8nL9x1/qU3U+wOdvGZCd6NIyqFGZNxwe605kmn9m1Y3iU8lFekIv/MbRs KgGzk4os0Uj70EK6ulPJd7VEB/AQ69hubpSEAJWOObpUa+6aAr8XTjyTuCebWT+IIR 1g+Ah5eczZ3TvJu6EGtfjazPe1waUuPVZPr8SspE4WzGXxMPdhuQQX8ZRBIWqsnBGL 3Mhqes70K5LsI366MyIQYkfrqbSmj6PeBXXCvXVqiNumGlNbB3PTUm1yZbVPNfNdKl AyX6R+0tuTJR2sjq+JBZYo0LwVWw45rFcAHo6DWSkwpktYqfyRM0rwBuTt7TEE6/B5 U7zEYoB7AsUNg== From: Michael Ellerman To: Christophe Leroy , Benjamin Herrenschmidt , Paul Mackerras Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc/32s: Fix RTAS machine check with VMAP stack In-Reply-To: <6ed0b74d-8d01-4a20-faed-891496fb77b4@csgroup.eu> References: <6ed0b74d-8d01-4a20-faed-891496fb77b4@csgroup.eu> Date: Thu, 24 Dec 2020 12:05:43 +1100 Message-ID: <87im8s6mjc.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christophe Leroy writes: > Le 22/12/2020 =C3=A0 08:11, Christophe Leroy a =C3=A9crit=C2=A0: >> When we have VMAP stack, exception prolog 1 sets r1, not r11. > > But exception prolog 1 uses r1 to setup r1 when machine check happens in = kernel. > So r1 must be restored when the branch is not taken. See subsequent patch= I just sent out. OK. This is still on the tip of fixes, so I'll rewind it to drop this commit, and then apply this and the fixup as one patch next week. cheers