Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1608694025-121050-1-git-send-email-yejune.deng@gmail.com>
 <20201223103623.mxjsmitdmqsx6ftd@steredhat> <3c013151-37de-1ef0-e989-9f871665d650@gmail.com>
In-Reply-To: <3c013151-37de-1ef0-e989-9f871665d650@gmail.com>
From:   Yejune Deng <yejune.deng@gmail.com>
Date:   Thu, 24 Dec 2020 09:38:26 +0800
Message-ID: <CABWKuGXfBxeQv7HpVz9J97x0deoSNxUaVRxCToX0C_FTSs=1QQ@mail.gmail.com>
Subject: Re: [PATCH] io_uring: remove io_remove_personalities()
To:     Pavel Begunkov <asml.silence@gmail.com>, sgarzare@redhat.com
Cc:     viro@zeniv.linux.org.uk, axboe@kernel.dk,
        linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

OK=EF=BC=8CI will adopt it and resubmit.

On Wed, Dec 23, 2020 at 8:45 PM Pavel Begunkov <asml.silence@gmail.com> wro=
te:
>
> On 23/12/2020 10:36, Stefano Garzarella wrote:
> > On Wed, Dec 23, 2020 at 11:27:05AM +0800, Yejune Deng wrote:
> >> The function io_remove_personalities() is very similar to
> >> io_unregister_personality(),but the latter has a more reasonable
> >> return value.
> >>
> >> Signed-off-by: Yejune Deng <yejune.deng@gmail.com>
> >> ---
> >> fs/io_uring.c | 25 ++++++-------------------
> >> 1 file changed, 6 insertions(+), 19 deletions(-)
> >
> > The patch LGTM, maybe as an alternative you can leave io_remove_persona=
lity() with the interface needed by idr_for_each() and implement io_unregis=
ter_personality() calling io_remove_personality() with the right parameters=
.
>
> Right, don't replace sane types with void * just because.
> Leave well-typed io_unregister_personality() and call it from
> io_remove_personalities().
>
>
> Also
>  * idr_for_each() - Iterate through all stored pointers.
>  ...
>  * If @fn returns anything other than %0, the iteration stops and that
>  * value is returned from this function.
>
> For io_remove_personality() iod=3D=3DNULL should not happen because
> it's under for_each and synchronised, but leave the return value be
>
> io_remove_personality(void *, ...)
> {
>         struct io_ring_ctx *ctx =3D data;
>
>         io_unregister_personality(ctx, id);
>         return 0;
> }
>
> --
> Pavel Begunkov