Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] bcache: set pdev_set_uuid before scond loop iteration
To:     Yi Li <yili@winhong.com>
Cc:     yilikernel@gmail.com, kent.overstreet@gmail.com,
        linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20201224015355.358211-1-yili@winhong.com>
From:   Coly Li <colyli@suse.de>
Message-ID: <a39ce88d-6955-6f3c-b064-d51cd8bd71e3@suse.de>
Date:   Thu, 24 Dec 2020 14:14:33 +0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0)
 Gecko/20100101 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <20201224015355.358211-1-yili@winhong.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/24/20 9:53 AM, Yi Li wrote:
> There is no need to reassign pdev_set_uuid in the second loop iteration,
> so move it to the place before second loop.
> 
> Signed-off-by: Yi Li <yili@winhong.com>

Added into my for-next directory. Thanks.

Coly Li

> ---
>  drivers/md/bcache/super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
> index a4752ac410dc..6aa23a6fb394 100644
> --- a/drivers/md/bcache/super.c
> +++ b/drivers/md/bcache/super.c
> @@ -2644,8 +2644,8 @@ static ssize_t bch_pending_bdevs_cleanup(struct kobject *k,
>  	}
>  
>  	list_for_each_entry_safe(pdev, tpdev, &pending_devs, list) {
> +		char *pdev_set_uuid = pdev->dc->sb.set_uuid;
>  		list_for_each_entry_safe(c, tc, &bch_cache_sets, list) {
> -			char *pdev_set_uuid = pdev->dc->sb.set_uuid;
>  			char *set_uuid = c->set_uuid;
>  
>  			if (!memcmp(pdev_set_uuid, set_uuid, 16)) {
>