From: Ingo Oeser <ioe-lkml@rameria.de>
To: "Randy.Dunlap" <rdunlap@xenotime.net>
Subject: Re: CodingStyle (was: Re: sound/pci/hda/intel_hda: small cleanups)
Date: Wed, 6 Sep 2006 09:23:19 +0200
User-Agent: KMail/1.9.3
Cc: Pavel Machek <pavel@ucw.cz>, Takashi Iwai <tiwai@suse.de>,
       Andrew Morton <akpm@osdl.org>,
       kernel list <linux-kernel@vger.kernel.org>, perex@suse.cz,
       alsa-devel@alsa-project.org, pshou@realtek.com.tw
References: <20060831123706.GC3923@elf.ucw.cz> <20060905080813.GE1958@elf.ucw.cz> <20060905084352.1ced999e.rdunlap@xenotime.net>
In-Reply-To: <20060905084352.1ced999e.rdunlap@xenotime.net>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200609060923.22459.ioe-lkml@rameria.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 825
Lines: 26

Hi,

On Tuesday, 5. September 2006 17:43, Randy.Dunlap wrote:
> Is there an acceptable way to leave source code in a file but
> render it unused?  Like #if 0/#endif or #if BOGUS_SYMBOL/#endif ?

They are to reading like gaps in a road.

If you really need to keep unused code for reference
just do it in your LOCAL repository.

There are exceptions where you remove the last user of code 
in one patch and a different developer just needs this code
for his new stuff in another patch.

In this case an #if 0/#endif is quite common to reduce merging
conflicts.

Regards

Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/