Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp6528989pxu; Thu, 24 Dec 2020 05:02:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJzpFYS6y6R1HiZuctDfZlvp2EJCH+LnaHlyWd5YRZSnaOU/c80QDIrxrRKIY/GYh80GS6zk X-Received: by 2002:a17:907:20f1:: with SMTP id rh17mr28013611ejb.147.1608814938365; Thu, 24 Dec 2020 05:02:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608814938; cv=none; d=google.com; s=arc-20160816; b=xmKxGYDwDmKhhkgSOAmh5V63e9gs3zkT+6SIztU5z2qF2WF2hTY38Y6WH4EqDxB/B1 jr/hdo9CZmWtcKxvbuMJpDfI00oQ5Gmxw3fX2GT7bM99OGckj7Bwrr8YP71QftI1r2qy tuKyJUAkyhYhISFKkiYJw60GlpaUd5AI8R6SxoR9R3OIF6AorCFKBs4DCLc5Y4ppglHa 2oekigU4BeDvveUV04Cx04myBf+RRPZ4Je1rwJMh2LpgqgGjcd6g6Na46+fGWdcm79OM IVwHp/fAAd8BmOQR6WJyLAj+BtodJ6+0rdhvRsGvJVtNW+tcq1/fq/UgVp+Qqs4zGMXq 3jiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=/Jr9F/690UBbYbyn+k3sooKcCVDtYkNF4Oiu8+df2GA=; b=D+BC8QLLj8glH4PkaNybMUirXf1R64RB8nvwtJ0DJT1Tyq8L5Tg4E4WcLgQZXYNK5b gZF0SAV636yyqQTKyWhlf0hsRNhUymadRyKI/uLc3Y31aJsqXBtS+6NGxgb1IJPUz/Qg S1JZmbeyJFsgrC64zJzPMT+rzAZuOEYzgJ8eLhAmOyuyE85o7ZihtTQXoYAHV9BQnrkm cgD25spDDO+vvw4j2A2LjRzncGINHC0pDEo+gxNIY4kXdh68z6en2uW/82pcqF3g1LHd ORkFSGME6AoquQZFu8T1p6/jOOf7yqTqmX5V0I0wsS11FQVJXEgzD/1GI/s0LEuYzoTj P5/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ZB+QyLHB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t19si15006808edt.283.2020.12.24.05.01.55; Thu, 24 Dec 2020 05:02:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ZB+QyLHB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728667AbgLXNAd (ORCPT + 99 others); Thu, 24 Dec 2020 08:00:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726931AbgLXNAc (ORCPT ); Thu, 24 Dec 2020 08:00:32 -0500 Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24E78C061794; Thu, 24 Dec 2020 04:59:52 -0800 (PST) Received: by mail-pg1-x534.google.com with SMTP id v19so1508043pgj.12; Thu, 24 Dec 2020 04:59:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/Jr9F/690UBbYbyn+k3sooKcCVDtYkNF4Oiu8+df2GA=; b=ZB+QyLHBPwq1c/hPyEocJCrpP+Qv1Z4uI3xFhH7c28xOHWYOwrgDMW7TF0YNPVT/QD znWbPYCkBWXeAlgjPpawGjQGfgsx22JyEc+pvlsaD6+c6iI3upkLZF9j0RfYTrAg3ULf 84ch3aAu/KpqaEhUiq96pspRAl2CVvaEipAE/SUA41ej5xFnDyp6TGFkMRLBfn7WE7FA ET4EsM1GK9M/XCq2B+QELQVux4+N5ljD4Nkf4Wsqjol7HunhRe6uHAffC+UameXehfvb CK7tmYu6Zvve1LNcCshYsRhxIpbFAofYigclt6/sKLjg6XornOV5i1kNlLVCb6Z+Vmeb h12A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/Jr9F/690UBbYbyn+k3sooKcCVDtYkNF4Oiu8+df2GA=; b=BRSOo6IHgW/9ikM3PNfuwa013VSH+ATBTZauoN8jQidlvXy1uuZUErD5AjbWDFcBGb xvOEKzqmFWVGe2zlCmMIwouoRPfk7VdYN0YGgcgMrxBI0HHBSg07oAhnF4eSqmCS45HJ yKVuvzMJDjIi5C+NLpS44V6ud6FevNXmmFwr+l0cTLsvx1PEh3hy80Ndsy5L1Xp9QJmz fpLUq0Ck1NtPZzvPI2opH0PbDEXokvLtZX9N7PlG0pVj0jhINwJ8yU4bX6ErM3whtoV4 udcSKKfzpIUY+Z96eHPfoZzppkp6hCUMDCIE+n1UP1iqdKGhtdEUT24WVSPAsQKyhEzW FaGw== X-Gm-Message-State: AOAM532KjtMP3EU9ZrKUr6o1nx/m3MuB3x0HNy/YVJHkaql5iaE2eDiD JtSRE4ZpDFz+pXfqGvv3xgQxsI0Gf6oWDMRYTes= X-Received: by 2002:a63:74b:: with SMTP id 72mr28774234pgh.4.1608814790947; Thu, 24 Dec 2020 04:59:50 -0800 (PST) MIME-Version: 1.0 References: <20201223133528.55014-1-ribalda@chromium.org> <20201223133528.55014-9-ribalda@chromium.org> In-Reply-To: <20201223133528.55014-9-ribalda@chromium.org> From: Andy Shevchenko Date: Thu, 24 Dec 2020 14:59:34 +0200 Message-ID: Subject: Re: [PATCH v7 08/12] media: uvcvideo: Use dev_ printk aliases To: Ricardo Ribalda Cc: Laurent Pinchart , Mauro Carvalho Chehab , Linux Media Mailing List , Linux Kernel Mailing List , Joe Perches Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 23, 2020 at 3:39 PM Ricardo Ribalda wrote: > > Replace all the uses of printk() and uvc_printk() with its > equivalent dev_ alias macros. > Modify uvc_warn_once() macro to use dev_info instead printk(). ... > +#define uvc_warn_once(_dev, warn, fmt, ...) \ > +do { \ > + if (!test_and_set_bit(warn, &(_dev)->warnings)) \ > + dev_info(&(_dev)->udev->dev, fmt, ##__VA_ARGS__); \ > +} while (0) ... Why not to use dev_warn_once() instead? -- With Best Regards, Andy Shevchenko