Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 24 Dec 2020 10:12:45 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Tian Tao <tiantao6@hisilicon.com>
Cc:     peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com,
        alexander.shishkin@linux.intel.com, jolsa@redhat.com,
        namhyung@kernel.org, ast@kernel.org, daniel@iogearbox.net,
        andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com,
        john.fastabend@gmail.com, kpsingh@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf build: remove -Wnested-externs
Message-ID: <20201224131245.GD477817@kernel.org>
References: <1608812646-23489-1-git-send-email-tiantao6@hisilicon.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1608812646-23489-1-git-send-email-tiantao6@hisilicon.com>
Precedence: bulk

Em Thu, Dec 24, 2020 at 08:24:06PM +0800, Tian Tao escreveu:
> since commit c93e4aeed1be
> ("Makefile.extrawarn: remove -Wnested-externs warning")
> has removed this check, so it's not needed here.

But the above commit is for the kernel, scripts/Makefile.extrawarn isn't
included in tools/perf/

This is the one used:

[acme@five perf]$ grep nested-externs tools/scripts/Makefile.include
EXTRA_WARNINGS += -Wnested-externs
[acme@five perf]$

But since you're looking at this, you could consider adding
tools/scripts/Makefile.extrawarn out of tools/scripts/Makefile.include,
etc, to better mimic what is in the kernel sources :-)

Thanks,

- Arnaldo
 
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> ---
>  tools/perf/Makefile.config | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
> index ce8516e..b9e8634 100644
> --- a/tools/perf/Makefile.config
> +++ b/tools/perf/Makefile.config
> @@ -16,7 +16,7 @@ $(shell printf "" > $(OUTPUT).config-detected)
>  detected     = $(shell echo "$(1)=y"       >> $(OUTPUT).config-detected)
>  detected_var = $(shell echo "$(1)=$($(1))" >> $(OUTPUT).config-detected)
>  
> -CFLAGS := $(EXTRA_CFLAGS) $(filter-out -Wnested-externs,$(EXTRA_WARNINGS))
> +CFLAGS := $(EXTRA_CFLAGS) $(EXTRA_WARNINGS)
>  
>  include $(srctree)/tools/scripts/Makefile.arch
>  
> -- 
> 2.7.4
> 

-- 

- Arnaldo