Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peter Chen <peter.chen@nxp.com>
To:     =?iso-8859-1?Q?Pali_Roh=E1r?= <pali@kernel.org>
CC:     Mathias Nyman <mathias.nyman@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Gregory CLEMENT <gregory.clement@bootlin.com>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Tomasz Maciej Nowak <tmn505@gmail.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] usb: host: xhci: mvebu: make USB 3.0 PHY optional for
 Armada 3720
Thread-Topic: [PATCH] usb: host: xhci: mvebu: make USB 3.0 PHY optional for
 Armada 3720
Thread-Index: AQHW2UgQyk5+oV5VRE2UEkoGEW5gpKoFv+eAgAB1K4CAAAV7IA==
Date:   Thu, 24 Dec 2020 13:15:21 +0000
Message-ID: <DBBPR04MB797907A4C3D7666B867AE2F08BDD0@DBBPR04MB7979.eurprd04.prod.outlook.com>
References: <20201223162403.10897-1-pali@kernel.org>
 <20201224055425.GA27629@b29397-desktop>
 <20201224125347.z2ka7itpxuvboghq@pali>
In-Reply-To: <20201224125347.z2ka7itpxuvboghq@pali>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 394f538a-654e-4e4c-fe2b-08d8a80df7c2
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Dec 2020 13:15:21.7279
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: OrZ+3e8/zEgdI3kLjWtV3xuFsS8iL7iiSlrTAtM5d6yRXYKHS0eoamZWSNV/+y+Hxk9bQBvt4U08V0DiYt5+AQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7177
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

=20
> > > +	/* Old bindings miss the PHY handle */
> > > +	phy =3D of_phy_get(dev->of_node, "usb3-phy");
> > > +	if (IS_ERR(phy) && PTR_ERR(phy) =3D=3D -EPROBE_DEFER)
> > > +		return -EPROBE_DEFER;
> >
> > Doesn't need to judge IS_ERR(phy).
>=20
> Ok, I can remove it. I used same condition which is already in SATA and P=
CIe
> phy code.
>=20
> > > +	else if (IS_ERR(phy))
> > > +		goto phy_out;
> > > +
> > > +	ret =3D phy_init(phy);
> > > +	if (ret)
> > > +		goto phy_put;
> > > +
> > > +	ret =3D phy_set_mode(phy, PHY_MODE_USB_HOST_SS);
> > > +	if (ret)
> > > +		goto phy_exit;
> > > +
> > > +	ret =3D phy_power_on(phy);
> > > +	if (ret =3D=3D -EOPNOTSUPP) {
> > > +		/* Skip initializatin of XHCI PHY when it is unsupported by
> firmware */
> > > +		dev_warn(dev, "PHY unsupported by firmware\n");
> > > +		xhci->quirks |=3D XHCI_SKIP_PHY_INIT;
> > > +	}
> > > +	if (ret)
> > > +		goto phy_exit;
> > > +
> > > +	phy_power_off(phy);
> > > +phy_exit:
> > > +	phy_exit(phy);
> > > +phy_put:
> > > +	of_phy_put(phy);
> > > +phy_out:
> > > +
> >
> > You do power on and off again only want to know if PHY has already
> > powered at ATF, right?
>=20
> I need to know if power on/off procedure is supported by ATF. And if not
> (indicated by -EOPNOTSUPP) then I need to ensure that usb hdc code would =
not
> try to call phy_power_on() as it would cause failure as described in the =
commit
> message. You can look at those other two commits for PCIe and SATA. Same
> thing is needed for USB.

If not supported by ATF, then where to power on and off PHY since no other =
place calls PHY APIs? Is it always on?

Peter