Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750710AbWIFI5r (ORCPT ); Wed, 6 Sep 2006 04:57:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750714AbWIFI5r (ORCPT ); Wed, 6 Sep 2006 04:57:47 -0400 Received: from e35.co.us.ibm.com ([32.97.110.153]:15317 "EHLO e35.co.us.ibm.com") by vger.kernel.org with ESMTP id S1750710AbWIFI5q (ORCPT ); Wed, 6 Sep 2006 04:57:46 -0400 Message-ID: <44FE8D82.3060103@in.ibm.com> Date: Wed, 06 Sep 2006 14:27:38 +0530 From: Balbir Singh Reply-To: balbir@in.ibm.com Organization: IBM India Private Limited User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.6) Gecko/20060730 SeaMonkey/1.0.4 MIME-Version: 1.0 To: Pavel Emelianov Cc: Kirill Korotaev , Andrew Morton , Rik van Riel , CKRM-Tech , Linux Kernel Mailing List , Andi Kleen , Christoph Hellwig , Andrey Savochkin , Alan Cox , Hugh Dickins , Matt Helsley , Alexey Dobriyan , Oleg Nesterov , devel@openvz.org Subject: Re: [ckrm-tech] [PATCH 5/13] BC: user interface (syscalls) References: <44FD918A.7050501@sw.ru> <44FD9699.705@sw.ru> <44FDA024.7030700@in.ibm.com> <44FE86EF.3050101@openvz.org> In-Reply-To: <44FE86EF.3050101@openvz.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1583 Lines: 45 Pavel Emelianov wrote: > Balbir Singh wrote: >>> + >>> +asmlinkage long sys_set_bcid(bcid_t id) >>> +{ >>> + int error; >>> + struct beancounter *bc; >>> + struct task_beancounter *task_bc; >>> + >>> + task_bc = ¤t->task_bc; >> I was playing around with the bc patches and found that to make >> use of bc's, I had to actually call set_bcid() and then exec() a >> task/shell so that the id would stick around. Would you consider > That sounds very strange as sys_set_bcid() actually changes current's > exec_bc. > One note is about mm's bc - mm obtains new bc only after fork or exec - > that's > true. But kmemsize starts charging right after the sys_set_bcid. I was playing around only with kmemsize. I think the reason for my observation is this bash --> (my utility) --> set_bcid() Since bash spawns my utility in a separate process, it creates and assigns a bean counter to it and then my utility exits. Unless it spawns/exec()'s a new shell, the beancounter is freed when the task exits (my utility). >> changing sys_set_bcid to sys_set_task_bcid() or adding a new >> system call sys_set_task_bcid()? We could pass the pid that we >> intend to associate with the new id. This also means we'll need >> locking around to protect task->task_bc. > -- Balbir Singh, Linux Technology Center, IBM Software Labs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/