Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <9ece49fa7b0025d1d639859082f0408bbe5f4f49.camel@perches.com>
Subject: Re: [PATCH 2/2] checkpatch: kconfig: add missing types to regex
From:   Joe Perches <coupons@perches.com>
To:     Nicolai Fischer <nicolai.fischer@fau.de>,
        linux-kernel@vger.kernel.org
Cc:     apw@canonical.com, johannes.czekay@fau.de,
        linux-kernel@i4.cs.fau.de, akpm@linux-foundation.org
Date:   Fri, 25 Dec 2020 09:42:12 -0800
In-Reply-To: <4899798f-46b9-32ee-4d1e-ab2b5833da08@fau.de>
References: <a9797282-84c3-2c8f-73a0-d751a8201541@fau.de>
         <1f3b50a6f343dd252c043b2e5b7d47bca8514ee7.camel@perches.com>
         <5d7cef4f-071d-0504-74df-bd944a11dd70@fau.de>
         <fa637be6bb02336a3df6e3c3fdc800b9b17d079f.camel@perches.com>
         <4899798f-46b9-32ee-4d1e-ab2b5833da08@fau.de>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.38.1-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 2020-12-25 at 18:27 +0100, Nicolai Fischer wrote:
> On 12/21/20 6:17 PM, Joe Perches wrote:
[]
> > The message you used:
> > +                               WARN("CONFIG_DESCRIPTION",
> > +                                       "help text is not indented 2 spaces more than the help keyword\n" . $herecurr);
> > 
> > is IMO a bit oddly phrased and could/should test only
> > the first line after the help keyword and show the help
> > line using $hereprev.
> > 
> > The problem with $herecurr is, that it always contains the first line of the Kconfig option.
> The loop which actually determines if the warning is to be displayed, leaves $herecurr and likewise $hereprev unaffected.
> 
> So printing $hereprev would unfortunately not be any more helpful than $herecurr.

> Because $herecurr and $hereprev also contain the line number, among other things, I am not sure what would be the best way
> to address this.

There is a mechanism to create an output message block: get_stat_real
that could be used.