Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v4 2/4] spi: ls7a: Add YAML schemas
To:     Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Mark Brown <broonie@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        ThomasBogendoerfer <tsbogend@alpha.franken.de>
References: <1608892552-15457-1-git-send-email-zhangqing@loongson.cn>
 <1608892552-15457-2-git-send-email-zhangqing@loongson.cn>
 <7d26a91a-f463-9ae4-8420-28a1b591053b@flygoat.com>
Cc:     linux-spi@vger.kernel.org, Huacai Chen <chenhc@lemote.com>,
        devicetree@vger.kernel.org, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org
From:   zhangqing <zhangqing@loongson.cn>
Message-ID: <4f83176f-64a9-ebf1-8446-bac9f9ee9c59@loongson.cn>
Date:   Sat, 26 Dec 2020 14:31:55 +0800
User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <7d26a91a-f463-9ae4-8420-28a1b591053b@flygoat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi，Jiaxun

Thank you for your reply.

I will also delete the num chipelects attribute in the device tree.

And I will send v5 in the soon.

Thanks,

-Qing

On 12/26/2020 11:31 AM, Jiaxun Yang wrote:
> 在 2020/12/25 下午6:35, Qing Zhang 写道:
>> Switch the DT binding to a YAML schema to enable the DT validation.
>>
>> Signed-off-by: Qing Zhang <zhangqing@loongson.cn>
>> ---
>>
>> v4: fix warnings/errors about running 'make dt_binding_check'
>>
>> ---
>>   .../devicetree/bindings/spi/loongson,spi-ls7a.yaml | 46 
>> ++++++++++++++++++++++
>>   1 file changed, 46 insertions(+)
>>   create mode 100644 
>> Documentation/devicetree/bindings/spi/loongson,spi-ls7a.yaml
>>
>> diff --git 
>> a/Documentation/devicetree/bindings/spi/loongson,spi-ls7a.yaml 
>> b/Documentation/devicetree/bindings/spi/loongson,spi-ls7a.yaml
>> new file mode 100644
>> index 0000000..8cc9bc5
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/spi/loongson,spi-ls7a.yaml
>> @@ -0,0 +1,46 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/spi/loongson,spi-ls7a.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Loongson LS7A PCH SPI Controller
>> +
>> +maintainers:
>> +  - Qing Zhang <zhangqing@loongson.cn>
>> +
>> +description: |
>> +  This controller can be found in Loongson-3 systems with LS7A PCH.
>> +
>> +properties:
>> +  compatible:
>> +    const: loongson,ls7a-spi
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - num-chipselects
>
> num-chipselects never parsed in code?
>
> Thanks.
>
> - Jiaxun
>
>
>
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    pci {
>> +        #address-cells = <3>;
>> +        #size-cells = <2>;
>> +
>> +        spi@16,0 {
>> +        compatible = "pci0014,7a0b.0",
>> +                        "pci0014,7a0b",
>> +                        "pciclass088000",
>> +                        "pciclass0800";
>> +
>> +        reg = <0xb000 0x0 0x0 0x0 0x0>;
>> +        num-chipselects = <0>;
>> +        };
>> +    };
>> +
>> +...