Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp8477534pxu; Sun, 27 Dec 2020 07:50:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJwGtd6hiuxBBoG/sNKfWTlY0vSc+cKOoDSFl1NYz218BOsWsizkkcSfkS8G6bajIGd9wEUy X-Received: by 2002:a05:6402:513:: with SMTP id m19mr39148820edv.244.1609084242223; Sun, 27 Dec 2020 07:50:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609084242; cv=none; d=google.com; s=arc-20160816; b=XfFZpwoPxFDdxaKjaOFSsBEzZkRrJvzleXyEYTSkbK+JqT2zbheYaHApKF1eh7WcZw 4idf65+lr1L8X6mTJfkRMuzlvKZ21K22rCEi7RXELcOJg3/VlI28LeAjcClR9LQ2oaik /xYrkJEtvhxW5g6/3PSNRVCJImHIQyXZon1OY6R2Fa17YdN25OMmBTF+WvsYVQnFIKzJ UkjZXG8FyFDtOkbZ0/XUbxMv6GFApkl9/s8PlKPgtoINdviYEW+jMMb3dkg+cH7215Yk esElvyUVdpYKaHXg7G8pElp/6II9qaokGbsdV1WyrO64qHwxhstSJd/PjT+jOM5u0MkQ YbHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from; bh=+vbMCP3m0drB3kqr1Br/k0RTMdtIPk1H0MADn0xFCkk=; b=WBdrEMknog3RpM9UpPPqJqWb4F4gnMi1iDRFZv5/KKQhPaUzHQ3eDtgNzelJtyfw8A GZt8DiX1jrY/Qk1CQg+bwUJkfNco04ZYLx7d+6QHBA6V+XZzDFjC5AfvXMye43L1ft3+ TfyvBh7y1cWQQg++IlJmOsKMTv1FTkipomrTo22w7cQ1LQg/J1NCtk+msVEiJAvCTWer 5CPqI+NCJCqlsU+oPPKMmaQijWTrPpMb6qh/GEsRyZr/4MgZT9FyVLp6Ph+rlQeNa6yM 6lnsTIE04RtGlBH0vpAmABYTqtvrAIno2W6DgfrMNPFteez04GpNj+RlAUn3M+xKzbcB vetw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m3si17795314ejr.562.2020.12.27.07.50.06; Sun, 27 Dec 2020 07:50:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726232AbgL0Psa (ORCPT + 99 others); Sun, 27 Dec 2020 10:48:30 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:52309 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726137AbgL0Ps3 (ORCPT ); Sun, 27 Dec 2020 10:48:29 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4D3lRt251Jz1qs0H; Sun, 27 Dec 2020 16:47:21 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4D3lRs3YGfz1qs5B; Sun, 27 Dec 2020 16:47:21 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id MaF-BA8HcyKT; Sun, 27 Dec 2020 16:47:20 +0100 (CET) X-Auth-Info: wKiVj1aH/fhPcaBIDfQMhJdTKsNwHLBrLIuElT3Ea3nTGQdZmhhFzFJfZDSSgq0l Received: from igel.home (ppp-46-244-172-159.dynamic.mnet-online.de [46.244.172.159]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Sun, 27 Dec 2020 16:47:20 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id 3852E2C35D1; Sun, 27 Dec 2020 16:47:20 +0100 (CET) From: Andreas Schwab To: Defang Bo Cc: gerg@linux-m68k.org, geert@linux-m68k.org, linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] m68k: let clk_enable() return immediately if clk is NULL References: <1609079753-4038536-1-git-send-email-bodefang@126.com> X-Yow: HELLO, everybody, I'm a HUMAN!! Date: Sun, 27 Dec 2020 16:47:20 +0100 In-Reply-To: <1609079753-4038536-1-git-send-email-bodefang@126.com> (Defang Bo's message of "Sun, 27 Dec 2020 22:35:53 +0800") Message-ID: <87bleffdyv.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Dez 27 2020, Defang Bo wrote: > diff --git a/arch/m68k/coldfire/clk.c b/arch/m68k/coldfire/clk.c > index 7bc666e..cf1ed97 100644 > --- a/arch/m68k/coldfire/clk.c > +++ b/arch/m68k/coldfire/clk.c > @@ -90,6 +90,9 @@ EXPORT_SYMBOL(clk_get); > int clk_enable(struct clk *clk) > { > unsigned long flags; > + if (!clk) > + return; That fails to return a value. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."