Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp8484350pxu; Sun, 27 Dec 2020 08:05:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJy4pJr83PDdYmZUtXt3GBfxyA9YG7E8jJmHmCLAmCh3eLeVCuQODlo7FEzugl0DKQPMMSGy X-Received: by 2002:a17:906:5796:: with SMTP id k22mr38002447ejq.435.1609085106203; Sun, 27 Dec 2020 08:05:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609085106; cv=none; d=google.com; s=arc-20160816; b=RmNplrTNhmRF8sN6rqDSUg8YVtQfYLRT43pxNLNwjuJcFBwdqphX+AKxNtByV0sIay U4wyq/MhU3HgDGR4yIO7JpH4mnQjgg3BskgsEBmR+f8vTGv64i6Ko7Gkz1HzbQBH57i2 JNm3kRwF4fd7gSUL7YIxb+o3tmAaQ1IBJAav/ln3gedLNFTEIC/1IE0Z2K0bHpcoKDte vliTNEJOlinU37w6UY2RPMXTT1cha79/Xd1luCeF4nCPnQnm7C3LI87EpJevcx/c5Swd uHQFdSRSnyCt0NQgieReMg/i8tVncFt79jXypMEhe7xcgSYGhys00QnD3MJUe4sWzbMI zokg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=kWGj17mP4rB4wbLa/GmAgRKTLYiHOjq4w7H9p33hVZM=; b=Y5/2pK5U/cBi63FGs3GwZAxFSMAbP9URlGfOo11tVeCo7ACgEZPqPMS+F2OhVe4jjT QwBUHKz2lNa6uUg+qGvtHBm7D7Ua356MqyqXS3Rs9IeAbOzkvbXwMi/jOaqknRXDqCLn bZSpe/HhneHojkfzZ/GJpfexHsWHZez6g8/S6kQwUgC0B+zgB/t1M/dYmq0La61f4M89 rVYD/1gxEKEiweB0M1LB0z0b1shb1HgXyVGNQgFZ//81QUq2k4JNa1/52h2apzMhb5LS n4n4c4xsXQBcaxpQ4/N9wbdp8R+jLgiGIhboECNSKuYayMpATlDGX/Tsn5ZsEDUZ3wLM k4mA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=l7CHi1d9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u7si16441759ejy.363.2020.12.27.08.04.30; Sun, 27 Dec 2020 08:05:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=l7CHi1d9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726204AbgL0QDB (ORCPT + 99 others); Sun, 27 Dec 2020 11:03:01 -0500 Received: from mail.kernel.org ([198.145.29.99]:57704 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726117AbgL0QDB (ORCPT ); Sun, 27 Dec 2020 11:03:01 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7203122512; Sun, 27 Dec 2020 16:02:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609084940; bh=0vg7M7y/o+3nZ+KECAO25hYa8OZo8S9gmKnQKy+rQgQ=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=l7CHi1d9H3wJjUMl620CzmmYVVm4e9EiZsR4nSdzppWa3b0hZN45aCyo3bzVk77Rc bJORCoqNAdk2W6q5u1NhQ3/VS65eRT+svItR9NqtsnarWS79F7jAKjljQFNihBAhFZ VbBmshpNTHpuNk1YniBqPo4UnLy9iVyB7+rmiVinf5c2I/sCz6LJZxXjazrp06gjBR XFOngjcPKHFn3BF6jeUF4uBbxroee0rKK2+391YQypknuUliXNWR+15kl0RAPQDTiG 01n4eWI7RBeAVqbVQyZEKTXEHGGDjB/65VedMGcxRmx21uPIcXtXmB7Vm4PjXCnUF1 K+J5nhLRzsgWw== Received: by paulmck-ThinkPad-P72.home (Postfix, from userid 1000) id 34DBE35226B3; Sun, 27 Dec 2020 08:02:20 -0800 (PST) Date: Sun, 27 Dec 2020 08:02:20 -0800 From: "Paul E. McKenney" To: Lai Jiangshan Cc: Hillf Danton , LKML , Valentin Schneider , Peter Zijlstra , Qian Cai , Vincent Donnefort , Lai Jiangshan , Tejun Heo Subject: Re: [PATCH -tip V2 00/10] workqueue: break affinity initiatively Message-ID: <20201227160220.GK2657@paulmck-ThinkPad-P72> Reply-To: paulmck@kernel.org References: <20201218170919.2950-1-jiangshanlai@gmail.com> <20201226103421.6616-1-hdanton@sina.com> <20201226145239.GJ2657@paulmck-ThinkPad-P72> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 27, 2020 at 10:08:51PM +0800, Lai Jiangshan wrote: > On Sat, Dec 26, 2020 at 10:52 PM Paul E. McKenney wrote: > > > > > > > Can you please specify a bit what you encountered in rcutorture > > > before this patchset? You know we cant have a correct estimation > > > of the fix diameter without your help. > > > > > It triggers the following in sched_cpu_dying() in kernel/sched/core.c, > > exactly the same as for Lai Jiangshan: > > > > BUG_ON(rq->nr_running != 1 || rq_has_pinned_tasks(rq)) > > > > Which is in fact the "this" in my earlier "rcutorture hits this". ;-) > > > > Thanx, Paul > > > > Hi, Hillf > > https://lkml.org/lkml/2020/12/22/141 > > >From the email, I think rcutorture encountered the same problem. > > Hi, Paul > > I'm sorry to forget to add your Tested-by. No need to apologize, especially given that I didn't get around to testing it until after it was pulled into -tip. ;-) Thank you for the patch series! Thanx, Paul