Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 27 Dec 2020 19:46:26 +0100
Message-ID: <s5h4kk7dr3x.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Jaroslav Kysela <perex@perex.cz>
Cc:     Ravulapati Vishnu vardhan rao 
        <Vishnuvardhanrao.Ravulapati@amd.com>, Alexander.Deucher@amd.com,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
        Akshu Agrawal <akshu.agrawal@amd.com>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Vijendar Mukunda <Vijendar.Mukunda@amd.com>,
        "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." 
        <alsa-devel@alsa-project.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: amd:Replacing MSI with Legacy IRQ model
In-Reply-To: <9f1df5a9-f2ab-33da-3111-c01db88912b4@perex.cz>
References: <20201222115929.11222-1-Vishnuvardhanrao.Ravulapati@amd.com>
        <9f1df5a9-f2ab-33da-3111-c01db88912b4@perex.cz>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Sun, 27 Dec 2020 19:03:28 +0100,
Jaroslav Kysela wrote:
> 
> Dne 22. 12. 20 v 12:59 Ravulapati Vishnu vardhan rao napsal(a):
> > When we try to play and capture simultaneously we see that
> > interrupts are genrated but our handler is not being acknowledged,
> > After investigating further more in detail on this issue we found
> > that IRQ delivery via MSI from the ACP IP is unreliable and so sometimes
> > interrupt generated will not be acknowledged so MSI model shouldn't be used
> > and using legacy IRQs will resolve interrupt handling issue.
> 
> What is the real culprit? It's hw bug? If not, it would be better to fix the
> PCI code or the irq handler.

I'm not surprised if it's a hardware "feature".  There are lots of
deny list and quirks about disabling MSI in HD-audio controller code,
after all.


Takashi