Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201227200000.28526-1-clabbe@baylibre.com> <25142918.GuFC1uy7vR@jernej-laptop>
In-Reply-To: <25142918.GuFC1uy7vR@jernej-laptop>
From:   Chen-Yu Tsai <wens@csie.org>
Date:   Mon, 28 Dec 2020 10:36:08 +0800
Message-ID: <CAGb2v67nG1tCG7dUb3CVtQkOiWHQ9KdavCGSEihX_=nRF6wMaA@mail.gmail.com>
Subject: Re: [linux-sunxi] Re: [PATCH RESEND] ARM: configs: sunxi: enable brcm wireless
To:     Corentin Labbe <clabbe@baylibre.com>
Cc:     Russell King <linux@armlinux.org.uk>,
        Maxime Ripard <mripard@kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-sunxi <linux-sunxi@googlegroups.com>,
        Jernej Skrabec <jernej.skrabec@siol.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Mon, Dec 28, 2020 at 4:03 AM Jernej Škrabec <jernej.skrabec@siol.net> wrote:
>
> Hi!
>
> Dne nedelja, 27. december 2020 ob 21:00:00 CET je Corentin Labbe napisal(a):
> > Lot of sunxi boards have BRCM wireless device, so let's enable necessary
> > options for it in our defconfig.
>
> Idea is good but modules (=m) instead of build in (=y) would be better. As you
> said, not all boards have such wifi and there is no need to make kernel binary
> bigger.

It's probably not very useful on its own if built in, since it also needs
firmware blobs, and when built in it doesn't wait for the rootfs to be
available.

ChenYu

> Best regards,
> Jernej
>
> >
> > Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> > ---
> >  arch/arm/configs/sunxi_defconfig | 23 ++++++++++++++++++++++-
> >  1 file changed, 22 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/configs/sunxi_defconfig
> > b/arch/arm/configs/sunxi_defconfig index a60c134c5e04..4891aefdef7d 100644
> > --- a/arch/arm/configs/sunxi_defconfig
> > +++ b/arch/arm/configs/sunxi_defconfig
> > @@ -52,7 +52,28 @@ CONFIG_STMMAC_ETH=y
> >  # CONFIG_NET_VENDOR_WIZNET is not set
> >  CONFIG_MICREL_PHY=y
> >  CONFIG_REALTEK_PHY=y
> > -# CONFIG_WLAN is not set
> > +CONFIG_WLAN=y
> > +# CONFIG_WLAN_VENDOR_ADMTEK is not set
> > +# CONFIG_WLAN_VENDOR_ATH is not set
> > +# CONFIG_WLAN_VENDOR_ATMEL is not set
> > +CONFIG_WLAN_VENDOR_BROADCOM=y
> > +# CONFIG_WLAN_VENDOR_CISCO is not set
> > +# CONFIG_WLAN_VENDOR_INTEL is not set
> > +# CONFIG_WLAN_VENDOR_INTERSIL is not set
> > +# CONFIG_WLAN_VENDOR_MARVELL is not set
> > +# CONFIG_WLAN_VENDOR_MEDIATEK is not set
> > +# CONFIG_WLAN_VENDOR_MICROCHIP is not set
> > +# CONFIG_WLAN_VENDOR_RALINK is not set
> > +# CONFIG_WLAN_VENDOR_REALTEK is not set
> > +# CONFIG_WLAN_VENDOR_RSI is not set
> > +# CONFIG_WLAN_VENDOR_ST is not set
> > +# CONFIG_WLAN_VENDOR_TI is not set
> > +# CONFIG_WLAN_VENDOR_ZYDAS is not set
> > +# CONFIG_WLAN_VENDOR_QUANTENNA is not set
> > +CONFIG_CFG80211=y
> > +CONFIG_CFG80211_WEXT=y
> > +CONFIG_MAC80211=y
> > +CONFIG_BRCMFMAC=y
> >  CONFIG_INPUT_EVDEV=y
> >  CONFIG_KEYBOARD_SUN4I_LRADC=y
> >  # CONFIG_INPUT_MOUSE is not set
>
>
>
>
> --
> You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com.
> To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/25142918.GuFC1uy7vR%40jernej-laptop.