Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp8764658pxu; Sun, 27 Dec 2020 19:22:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJyOEkecy/JBWMvpAG41XZhZRquLvAxpjyEn43NWdf+XqBM/Y34Y4/T3D/WIiRFbTG+NoOGL X-Received: by 2002:a17:906:ce3c:: with SMTP id sd28mr39868391ejb.485.1609125720558; Sun, 27 Dec 2020 19:22:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609125720; cv=none; d=google.com; s=arc-20160816; b=ybrHx5aseNHlXSiHV53jO7gpzQVTg04rt2aXNktNV3ksh+tefWYYKpZqehnS8BV4ZW fh9BIdmWePh+RMKf/NEJ5w6Ce7yE5uhPHaM/tYEyUuH6O6nkNp1fWEq8vyRFARpJYKWN Ab0uuO8en0lj5/eWIPOXMNvmSgtmlMpAdcPO12a8iLRN/iMk02FE5G/nv4+3QSwcjU/A fN2xE1SCvst1ZyLL1ulKhk3qGBy0MiJpSPl2cUqm5MEtAfeDWuWiUlvqnSh+saeUI0tH a60CjqJMeKtUjYBazEv47id4zT8FGaMlKIZgxBWvy4RUvkr9jMEQuxjUjkrop6O9e73E 2IGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=jlGNLpbHIFdhwDQzG+Qa5dKugvebrbomzQHZ2GUDU0s=; b=JRXzRFw18vR1oaMsKkFnU2qerCow1ENrI2LuvQApdA1ViV8a2DMyCB5mV4szj2tpZg ePr81xc8wWU7wyYdQ1fA2Hbg9aRENQdrpy7S3gzgxiEAaa6YNJV6wjbdbUiF7SHP5qPp +J8a3F8iwPuHryQNuXXt9wwPaI3SF4cGmwR/i3C4muxkz5CqKgEOAzOzlEO8VU7vOyDr SEshcTvTFZJjGkUhB3muiLUi861Omr9MfajKGsVWFecWlxt81OAJ54z3awWGCRUtiE4e Bs+2g4Noux5GLdTKR/cjsNZo5gIzsmFmdSduvmCejOBMfxHuCm2HsXnfQaAzRbfWf3TI QjDg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ck16si19733352edb.36.2020.12.27.19.21.38; Sun, 27 Dec 2020 19:22:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726517AbgL1DTo (ORCPT + 99 others); Sun, 27 Dec 2020 22:19:44 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:9999 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726340AbgL1DTo (ORCPT ); Sun, 27 Dec 2020 22:19:44 -0500 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4D42n13hnVzhXwt; Mon, 28 Dec 2020 11:18:13 +0800 (CST) Received: from huawei.com (10.175.112.227) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.498.0; Mon, 28 Dec 2020 11:19:00 +0800 From: Xiangyang Yu To: , , CC: Subject: [PATCH] locking/qspinlock: Modify comments to adapt to code modification. Date: Mon, 28 Dec 2020 11:18:55 +0800 Message-ID: <20201228031855.1991595-1-yuxiangyang4@huawei.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.112.227] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function 'pv_wait_head_or_lock' comment is not modified in commit 625e88be1f41 ("locking/qspinlock: Merge 'struct __qspinlock' into 'struct qspinlock'"). Fix it. Signed-off-by: Xiangyang Yu --- kernel/locking/qspinlock_paravirt.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/kernel/locking/qspinlock_paravirt.h b/kernel/locking/qspinlock_paravirt.h index e84d21aa0722..0b7ecf4eb8b8 100644 --- a/kernel/locking/qspinlock_paravirt.h +++ b/kernel/locking/qspinlock_paravirt.h @@ -393,7 +393,7 @@ static void pv_kick_node(struct qspinlock *lock, struct mcs_spinlock *node) } /* - * Wait for l->locked to become clear and acquire the lock; + * Wait for lock->locked to become clear and acquire the lock; * halt the vcpu after a short spin. * __pv_queued_spin_unlock() will wake us. * @@ -447,9 +447,9 @@ pv_wait_head_or_lock(struct qspinlock *lock, struct mcs_spinlock *node) * when we observe _Q_SLOW_VAL in __pv_queued_spin_unlock() * we'll be sure to be able to observe our hash entry. * - * [S] [Rmw] l->locked == _Q_SLOW_VAL - * MB RMB - * [RmW] l->locked = _Q_SLOW_VAL [L] + * [S] [Rmw] lock->locked == _Q_SLOW_VAL + * MB RMB + * [RmW] lock->locked = _Q_SLOW_VAL [L] * * Matches the smp_rmb() in __pv_queued_spin_unlock(). */ -- 2.23.0