Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp8792859pxu; Sun, 27 Dec 2020 20:36:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJze3z3onTyPxBJmwpax52mkr9aK3BqJIAs6ezeuht6u/WQGlaC5gEvuXuesn9+cLKes/GAi X-Received: by 2002:a05:6402:d0a:: with SMTP id eb10mr5591521edb.305.1609130197857; Sun, 27 Dec 2020 20:36:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609130197; cv=none; d=google.com; s=arc-20160816; b=XVvaOybM6KWEVRHmoDMilZ/x1+YeTjCBBPv+U1/C5BX7lhgFefJUy2QsMT2Tmhp7U1 of3B/8sB6kSNVBOJmb/rw6/o890bNgV0RKZCjj/nrE/NtL/rtqEBnHD/5/Y+WPDjafrG 24KXnb5QCSdqy/lxqzNiZW0k55MMToaKCZdOtmNUgle314Sb3D/hlglgCQiVjW53GEQ0 LOEEeRcWpPAYwzn1Lyzl0aRFwhyr0T9KQRLPmm0Il0rR4wtKfEFztbI8t2WbqfaMkp6i 58Y7eofgi9Lu3rTT9bZQflgOOhXFsJTkkoSgO756lzIn0EbjX3kxPqUnsJRLcJQxsCop nXAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=xDaj2aGFc8Ryio1B37xmDRbgZ25x8BPX+LqRqApW28A=; b=xOWUNZ1PR8zFZLItRNhRRoeHe5liVo/TJkDOMZcN1Hw5/bzoPYBBp0JM8sTrRT8d0A qrrUJZioaAGSfGqHRh4TW5LnpL68VO9RfGEtR/FjrXHqg5Q3378kPLoaNPYB/GQfMJtr 9u3itFGqvT4XC0pdNWz3drW+2aNkxasxYETxfHVauBrTiPFzEzW+rC+J1mDq426xrRuR w9bxNdGdSSPS1nkHrhat48cpaShqMRQXw5YY5vksAkGBX0NsWI78OJ3cesBnoQeoq1Zm lG7hQZtXAxD7V9HAzBZ6+T7NpVSr4umM/VuPQk35zBEhjzZQ4YF0g0ppgZdh8w4JGSQk 1KQQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u13si19546932ejn.694.2020.12.27.20.36.15; Sun, 27 Dec 2020 20:36:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726480AbgL1Efw (ORCPT + 99 others); Sun, 27 Dec 2020 23:35:52 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:58309 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726485AbgL1Efw (ORCPT ); Sun, 27 Dec 2020 23:35:52 -0500 Received: from mail-pj1-f71.google.com ([209.85.216.71]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1ktkFR-0005R8-VN for linux-kernel@vger.kernel.org; Mon, 28 Dec 2020 04:35:10 +0000 Received: by mail-pj1-f71.google.com with SMTP id gt6so5635710pjb.7 for ; Sun, 27 Dec 2020 20:35:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=xDaj2aGFc8Ryio1B37xmDRbgZ25x8BPX+LqRqApW28A=; b=rjFq9qEKf1YmZN9d1rCvqC5PYwHphotVx4QEorRhjVxC66WItIcSGascXrL661RM48 gTA8bEfKHfkervFBDb1MLm+ElsdZ+F+QXq6vU67wvelV1Yt14DKUuFDz43jz2jFas2Wc p+BiorwkmUXf27AGEHQbdPIN2UOl0rP46cjt9okvbFLY/timFV92FsxalJ7qMaVkLDnc WYyoYkF83lyaUz0wIBQSQ7tRnwu3+DXwKexvHDm01mj9uds7oWgT4ltkaq3NWu4ExqCN slUd3GZUytVGri5g+sk0amIMh61as6ZOMG1TMVzwYjKE0VAEGqOtv81u7csqdt04XD1E TEyQ== X-Gm-Message-State: AOAM533G88fMIl2FV5INp+5UMCA98F7MZ+ji5z+pxfBY/o5BrvIJ6EWW 6E453WE5xfWWlxA1Udtf2LQh9Z8jN/FF9B20Bvtbj+wS8Gef0FXHpeJCSYujoSB/o3EwDrCnf/4 DXFJK1iEDVeEL/H0LsQqHJdWdSS5L8+mYvc7qJB6t X-Received: by 2002:a05:6a00:8c7:b029:19d:afa5:34e5 with SMTP id s7-20020a056a0008c7b029019dafa534e5mr39739021pfu.30.1609130108308; Sun, 27 Dec 2020 20:35:08 -0800 (PST) X-Received: by 2002:a05:6a00:8c7:b029:19d:afa5:34e5 with SMTP id s7-20020a056a0008c7b029019dafa534e5mr39739005pfu.30.1609130107999; Sun, 27 Dec 2020 20:35:07 -0800 (PST) Received: from Leggiero.taipei.internal (61-220-137-38.HINET-IP.hinet.net. [61.220.137.38]) by smtp.gmail.com with ESMTPSA id a1sm34567962pfo.56.2020.12.27.20.35.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Dec 2020 20:35:07 -0800 (PST) From: Po-Hsu Lin To: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Cc: po-hsu.lin@canonical.com, shuah@kernel.org, paulus@samba.org, benh@kernel.crashing.org, oohall@gmail.com, mpe@ellerman.id.au Subject: [PATCH] selftests/powerpc: make the test check in eeh-basic.sh posix compliant Date: Mon, 28 Dec 2020 12:34:59 +0800 Message-Id: <20201228043459.14281-1-po-hsu.lin@canonical.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The == operand is a bash extension, thus this will fail on Ubuntu with As the /bin/sh on Ubuntu is pointed to DASH. Use -eq to fix this posix compatibility issue. Fixes: 996f9e0f93f162 ("selftests/powerpc: Fix eeh-basic.sh exit codes") Signed-off-by: Po-Hsu Lin --- tools/testing/selftests/powerpc/eeh/eeh-basic.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/powerpc/eeh/eeh-basic.sh b/tools/testing/selftests/powerpc/eeh/eeh-basic.sh index 0d783e1..64779f0 100755 --- a/tools/testing/selftests/powerpc/eeh/eeh-basic.sh +++ b/tools/testing/selftests/powerpc/eeh/eeh-basic.sh @@ -86,5 +86,5 @@ echo "$failed devices failed to recover ($dev_count tested)" lspci | diff -u $pre_lspci - rm -f $pre_lspci -test "$failed" == 0 +test "$failed" -eq 0 exit $? -- 2.7.4