Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Manish Rangankar <mrangankar@marvell.com>
To:     "trix@redhat.com" <trix@redhat.com>,
        Nilesh Javali <njavali@marvell.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>
CC:     GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@marvell.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] scsi: qedi: add printf attribute to log function
Thread-Topic: [PATCH] scsi: qedi: add printf attribute to log function
Thread-Index: AQHW17X2wSuSr7TtZE6Xoo+9t4tRHqoMEcDw
Date:   Mon, 28 Dec 2020 06:14:24 +0000
Message-ID: <BYAPR18MB29986769E1F17A8AACAE038AD8D91@BYAPR18MB2998.namprd18.prod.outlook.com>
References: <20201221162335.3756353-1-trix@redhat.com>
In-Reply-To: <20201221162335.3756353-1-trix@redhat.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 874f4612-1603-48d1-5c6e-08d8aaf7d33d
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Dec 2020 06:14:24.9014
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vWmbVkIltXJToZD6Xt3csKqNwRxssOW6eMJCKvXvLZ58AGJSTTE1hfvKIxSVEFoR5mbLkIi+67y88lLJqf0RcA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR18MB3250
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343,18.0.737
 definitions=2020-12-28_04:2020-12-24,2020-12-28 signatures=0
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: trix@redhat.com <trix@redhat.com>
> Sent: Monday, December 21, 2020 9:54 PM
> To: Nilesh Javali <njavali@marvell.com>; Manish Rangankar
> <mrangankar@marvell.com>; jejb@linux.ibm.com;
> martin.petersen@oracle.com
> Cc: GR-QLogic-Storage-Upstream <GR-QLogic-Storage-
> Upstream@marvell.com>; linux-scsi@vger.kernel.org; linux-
> kernel@vger.kernel.org; Tom Rix <trix@redhat.com>
> Subject: [PATCH] scsi: qedi: add printf attribute to log function
>=20
> From: Tom Rix <trix@redhat.com>
>=20
> Attributing the function allows the compiler to more thoroughly check the
> use of the function with -Wformat and similar flags.
>=20
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/scsi/qedi/qedi_dbg.h | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/scsi/qedi/qedi_dbg.h b/drivers/scsi/qedi/qedi_dbg.h
> index 37d084086fd4..b2c9b0a2db6a 100644
> --- a/drivers/scsi/qedi/qedi_dbg.h
> +++ b/drivers/scsi/qedi/qedi_dbg.h
> @@ -78,13 +78,16 @@ struct qedi_dbg_ctx {
>  #define QEDI_INFO(pdev, level, fmt, ...)	\
>  		qedi_dbg_info(pdev, __func__, __LINE__, level, fmt,	\
>  			      ## __VA_ARGS__)
> -
> +__printf(4, 5)
>  void qedi_dbg_err(struct qedi_dbg_ctx *qedi, const char *func, u32 line,
>  		  const char *fmt, ...);
> +__printf(4, 5)
>  void qedi_dbg_warn(struct qedi_dbg_ctx *qedi, const char *func, u32 line=
,
>  		   const char *fmt, ...);
> +__printf(4, 5)
>  void qedi_dbg_notice(struct qedi_dbg_ctx *qedi, const char *func, u32
> line,
>  		     const char *fmt, ...);
> +__printf(5, 6)
>  void qedi_dbg_info(struct qedi_dbg_ctx *qedi, const char *func, u32 line=
,
>  		   u32 info, const char *fmt, ...);
>=20

Thanks,
Acked-by: Manish Rangankar <mrangankar@marvell.com>