Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp9010554pxu; Mon, 28 Dec 2020 04:19:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJzMSpk43y2VD8GSJs3ok1TI6bz61mvrMcNqpJBid4JtARlt16IXITc9DOD2+YAXWQ96jNh2 X-Received: by 2002:a50:ee8e:: with SMTP id f14mr41094805edr.176.1609157946933; Mon, 28 Dec 2020 04:19:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609157946; cv=none; d=google.com; s=arc-20160816; b=LMhlwYlo1+FpvJDKiOCgjcgQbvnUVKs3ihY+WSo7RD5oDQV3Z4oNY2mawNPhQ5RVJz g/gLf6RDLp9a8h7OFCxhgnK0505/MNX2GIa6302ubHQ62SDJU0+P8Lo2TOPbjswaA+Ff 9ftwbALoJ+cXtCF+HB7yO+VyY7u1lK26YhwIDoI949P6XtqAInK0GWJVKe2HLVeoYXxW LakYSRwEoY66lKvJlovRD+PHB5Q3Ak143Lf7UoOC7dSh/yew6FGSrlUz7dtk8UU6BoBe GvRvxOWQqSpeoB2xxT+rwrxLk8pu3f+98lFFv9js3oTTCBcRGRr5T6dU+S43FW/Ylf6a GE/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=I7L8aPFCp+Fz8sCe3NmPkcecJvCIGylayy6Pl56nU5w=; b=X3grk9ndUG1A4XQFFHwQxbx0+O/fxkPQM7sw1V6oy2g0dcY5VdtDKyL6+aO1dkSbej ONK1fNZOqLmfapMJ8qcQMMsMpHxcBvl/fn2KIZLzU78P7xgRV1H9/Zw+iaGiC/f28zaX NGHKW63ew7DJxGjCpRcspreP/+QC26Nz5rQ3t4OiQzeB3XfIC0FvtgXrU8r9tmCSJ4Q0 sgaQNjY2/x9Rr+lHhJsrg88wXUXswVFDxTLKR2WskpafpThrIamKsP62A0uxuD9zC5qc pNyvRlvvU3vaqLfOinLFtBLwYoYFDDQ1WALhCtU9NKRwa+grk/LK7okRpUT5RIyEE2sC w+Ew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bh14si7811181ejb.45.2020.12.28.04.18.44; Mon, 28 Dec 2020 04:19:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727489AbgL1MSR (ORCPT + 99 others); Mon, 28 Dec 2020 07:18:17 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:58756 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726847AbgL1MSR (ORCPT ); Mon, 28 Dec 2020 07:18:17 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: ezequiel) with ESMTPSA id 749891F44439 From: Ezequiel Garcia To: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kernel@collabora.com, Hans Verkuil , Laurent Pinchart , Ezequiel Garcia Subject: [PATCH] media: v4l2-async: Put fwnode after last access Date: Mon, 28 Dec 2020 09:17:25 -0300 Message-Id: <20201228121725.133898-1-ezequiel@collabora.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org fwnode_handle_put() should be called after the fwnode is last accessed. Fix it. Fixes: b98158d837ef ("media: v4l2-async: Accept endpoints and devices for fwnode matching") Signed-off-by: Ezequiel Garcia --- drivers/media/v4l2-core/v4l2-async.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c index e3ab003a6c85..1303c9b83138 100644 --- a/drivers/media/v4l2-core/v4l2-async.c +++ b/drivers/media/v4l2-core/v4l2-async.c @@ -78,6 +78,7 @@ static bool match_fwnode(struct v4l2_async_notifier *notifier, bool asd_fwnode_is_ep; bool sd_fwnode_is_ep; struct device *dev; + bool match; /* * Both the subdev and the async subdev can provide either an endpoint @@ -113,9 +114,10 @@ static bool match_fwnode(struct v4l2_async_notifier *notifier, other_fwnode = sd->fwnode; } - fwnode_handle_put(dev_fwnode); + match = (dev_fwnode == other_fwnode); - if (dev_fwnode != other_fwnode) + fwnode_handle_put(dev_fwnode); + if (!match) return false; /* -- 2.29.2