Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751061AbWIFN5K (ORCPT ); Wed, 6 Sep 2006 09:57:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751060AbWIFN5K (ORCPT ); Wed, 6 Sep 2006 09:57:10 -0400 Received: from relay03.pair.com ([209.68.5.17]:56330 "HELO relay03.pair.com") by vger.kernel.org with SMTP id S1751061AbWIFN5H (ORCPT ); Wed, 6 Sep 2006 09:57:07 -0400 X-pair-Authenticated: 71.197.50.189 Date: Wed, 6 Sep 2006 08:54:22 -0500 (CDT) From: Chase Venters X-X-Sender: root@turbotaz.ourhouse To: Chase Venters cc: Evgeniy Polyakov , lkml , David Miller , Ulrich Drepper , Andrew Morton , netdev , Zach Brown , Christoph Hellwig , Johann Borck Subject: Re: [take16 1/4] kevent: Core files. In-Reply-To: Message-ID: References: <1157543723488@2ka.mipt.ru> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 718 Lines: 22 On Wed, 6 Sep 2006, Chase Venters wrote: >> + if (start + num >= KEVENT_MAX_EVENTS || >> + start >= KEVENT_MAX_EVENTS || >> + num >= KEVENT_MAX_EVENTS) > > Since start and num are unsigned, the last two checks are redundant. If start > or num is individually >= KEVENT_MAX_EVENTS, start + num must be. > Actually, my early-morning brain code optimizer is apparently broken, because it forgot all about integer wraparound. Disregard please. > > Thanks, > Chase > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/