Message-ID: <44FEE3A6.1080009@sw.ru>
Date: Wed, 06 Sep 2006 19:05:10 +0400
From: Kirill Korotaev <dev@sw.ru>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.13) Gecko/20060417
MIME-Version: 1.0
To: Sam Ravnborg <sam@ravnborg.org>
CC: Andrew Morton <akpm@osdl.org>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       Andrey Mirkin <amirkin@sw.ru>
Subject: Re: [RFC][PATCH] fail kernel compilation in case of unresolved symbols
References: <44FD7FED.7000603@sw.ru> <20060905153159.GA13082@uranus.ravnborg.org>
In-Reply-To: <20060905153159.GA13082@uranus.ravnborg.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 928
Lines: 24

Sam Ravnborg wrote:
> On Tue, Sep 05, 2006 at 05:47:25PM +0400, Kirill Korotaev wrote:
> 
>>At stage 2 modpost utility is used to check modules.
>>In case of unresolved symbols modpost only prints warning.
>>
>>IMHO it is a good idea to fail compilation process in case of
>>unresolved symbols, since usually such errors are left unnoticed,
>>but kernel modules are broken.
> 
> 
> The primary reason why we do not fail in this case is that building
> external modules often result in unresolved symbols at modpost time.
> 
> And there is many legitime uses of external modules that we shall support.
ok. is it ok for you to introduce new Make target 'modules_check'?

Thanks,
Kirill
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/