Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp9087480pxu; Mon, 28 Dec 2020 06:19:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJyZWPKevv1QqVFGw6RiM1XtuL3ikPNWhJL0zyrwjZjNnrobcIxEYbXADOAVvwexv5SGrnCP X-Received: by 2002:a50:e8c4:: with SMTP id l4mr41996903edn.337.1609165180728; Mon, 28 Dec 2020 06:19:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609165180; cv=none; d=google.com; s=arc-20160816; b=LpxFZo1oN6gSaDqGUnenD5gOGNCa7doUWBNwsQgZLvOSe7j07rVywWGnZIz/wt3U4P pDmDUp7wEKtSBBdiDqfHuOBtg6AP9C11U0tM/0uauWD2X5rhB14kayincPc/vYC4K/tg UQNCR5qqc668kVsqYGAbgepol9rWZnjFdyQtOt+p94v+8Jyh+YKroSmXarLk4H8RM0It 8XPWvvhoeM48hidQqfp85f0P/49npLoyYXfQ4/EqxnuF3j5IQh3S9uwe+ay5wq+KBsGJ 55adWO/569nfrS3VQfdQ6F9RXIB/b0VawZeNqFlevRPqZF8wxVppJ6hPNKTiFNROPKhA vR/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=wBCqwT38yYhjrupDETQJ0AQXeNbtdZlfuxjRn2QUr84=; b=isHN7X6O40545MrWwBZ6xELXdm3bvOGg8ce2Yr4oYkUIEZTIs0rbU7L0PJSA+kBRuv vMTcc8d6QwNm7ftZtcf2RZIDooAT23KIF864koLfcZSl2upPHS/3DQ7K4t9DLt9/FEzR ZiDsVMnbM3rI6bJUBF2h2d4yDCm9eArCi1qBSrMs6BjMQphYscsosqB68GiokYkyreuB baky3QG4m8BRxerIwgIbm7pXinr9lJpUfR8Zz+CikHURex1bJsJyZwX12fKeooxFnsUA eCd26vUIudRaAyXhEARZ0PhJ9lUfCyg7M/1ZiFoZz4HGeTa2m8DNnaRpK68oWs8hBHoA sIsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=0VJrPquQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e25si18428947ejt.153.2020.12.28.06.19.18; Mon, 28 Dec 2020 06:19:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=0VJrPquQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2440710AbgL1OPi (ORCPT + 99 others); Mon, 28 Dec 2020 09:15:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:50406 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2440678AbgL1OPb (ORCPT ); Mon, 28 Dec 2020 09:15:31 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8DE2B207B2; Mon, 28 Dec 2020 14:14:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1609164890; bh=ru7VfCUzhDwXPSmUE9w67o+EJFfnR3QxtyIwwT1hSDE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0VJrPquQ1MMmTgYbpmqbNylFku/8hnt/s/zvGsCcWe9H1wZerFfjirkhqHyhexBFH Flsj+v2uxpk2cis0tAu5V4Kp2yzOMj1Lc9iO0J1xs8IiohxXdVXgSaOEcPsdCiMrOD 2yCwz/1T5qmk7T1AEy5DoUVp2+vvqXAFzxjlZMG0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jacopo Mondi , Arnd Bergmann , Sasha Levin Subject: [PATCH 5.10 335/717] staging: bcm2835: fix vchiq_mmal dependencies Date: Mon, 28 Dec 2020 13:45:33 +0100 Message-Id: <20201228125037.070890072@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201228125020.963311703@linuxfoundation.org> References: <20201228125020.963311703@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann [ Upstream commit 6c91799f59ed491a2b5bf5ef7c6d60306cda4e09 ] When the MMAL code is built-in but the vchiq core config is set to =m, the mmal code never gets built, which in turn can lead to link errors: ERROR: modpost: "vchiq_mmal_port_set_format" [drivers/staging/vc04_services/bcm2835-camera/bcm2835-v4l2.ko] undefined! ERROR: modpost: "vchiq_mmal_port_disable" [drivers/staging/vc04_services/bcm2835-camera/bcm2835-v4l2.ko] undefined! ERROR: modpost: "vchiq_mmal_port_parameter_set" [drivers/staging/vc04_services/bcm2835-camera/bcm2835-v4l2.ko] undefined! ERROR: modpost: "vchiq_mmal_component_finalise" [drivers/staging/vc04_services/bcm2835-camera/bcm2835-v4l2.ko] undefined! ERROR: modpost: "vchiq_mmal_port_connect_tunnel" [drivers/staging/vc04_services/bcm2835-camera/bcm2835-v4l2.ko] undefined! ERROR: modpost: "vchiq_mmal_component_enable" [drivers/staging/vc04_services/bcm2835-camera/bcm2835-v4l2.ko] undefined! ERROR: modpost: "vchiq_mmal_finalise" [drivers/staging/vc04_services/bcm2835-camera/bcm2835-v4l2.ko] undefined! ERROR: modpost: "vchiq_mmal_component_init" [drivers/staging/vc04_services/bcm2835-camera/bcm2835-v4l2.ko] undefined! ERROR: modpost: "vchiq_mmal_component_disable" [drivers/staging/vc04_services/bcm2835-camera/bcm2835-v4l2.ko] undefined! ERROR: modpost: "mmal_vchi_buffer_init" [drivers/staging/vc04_services/bcm2835-camera/bcm2835-v4l2.ko] undefined! ERROR: modpost: "vchiq_mmal_port_enable" [drivers/staging/vc04_services/bcm2835-camera/bcm2835-v4l2.ko] undefined! ERROR: modpost: "vchiq_mmal_version" [drivers/staging/vc04_services/bcm2835-camera/bcm2835-v4l2.ko] undefined! ERROR: modpost: "vchiq_mmal_submit_buffer" [drivers/staging/vc04_services/bcm2835-camera/bcm2835-v4l2.ko] undefined! ERROR: modpost: "vchiq_mmal_init" [drivers/staging/vc04_services/bcm2835-camera/bcm2835-v4l2.ko] undefined! ERROR: modpost: "mmal_vchi_buffer_cleanup" [drivers/staging/vc04_services/bcm2835-camera/bcm2835-v4l2.ko] undefined! ERROR: modpost: "vchiq_mmal_port_parameter_get" [drivers/staging/vc04_services/bcm2835-camera/bcm2835-v4l2.ko] undefined! Change the Kconfig to depend on BCM2835_VCHIQ like the other drivers, and remove the now redundant dependencies. Fixes: b18ee53ad297 ("staging: bcm2835: Break MMAL support out from camera") Acked-by: Jacopo Mondi Signed-off-by: Arnd Bergmann Link: https://lore.kernel.org/r/20201203223836.1362313-1-arnd@kernel.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/staging/vc04_services/vchiq-mmal/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/vchiq-mmal/Kconfig b/drivers/staging/vc04_services/vchiq-mmal/Kconfig index 500c0d12e4ff2..c99525a0bb452 100644 --- a/drivers/staging/vc04_services/vchiq-mmal/Kconfig +++ b/drivers/staging/vc04_services/vchiq-mmal/Kconfig @@ -1,6 +1,6 @@ config BCM2835_VCHIQ_MMAL tristate "BCM2835 MMAL VCHIQ service" - depends on (ARCH_BCM2835 || COMPILE_TEST) + depends on BCM2835_VCHIQ help Enables the MMAL API over VCHIQ interface as used for the majority of the multimedia services on VideoCore. -- 2.27.0