Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp9088262pxu; Mon, 28 Dec 2020 06:20:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJyppT43aZ9Co0duEVam1rw5vHbAYidzreWaVQrgGfsWoQdF14gu2r7nQq9GjIifRXV94LLr X-Received: by 2002:a05:6402:1c8a:: with SMTP id cy10mr42433797edb.151.1609165240050; Mon, 28 Dec 2020 06:20:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609165240; cv=none; d=google.com; s=arc-20160816; b=E42xDegtkmB4XaHyegpvNjEAxycjxU6LuE207w9ORMHtGVHoE7mBWm6NDPAmJh8LYe ilBgjGGVy8tHxQHqmE+7lz6H0bwcVKoDn6C3qH0tuIkgXYFkW0ZeKEn2gouYVJgnbg1R 5kBQYbxVv8qQcqyCUb4cE60FXUwnk/X5ave9tc877fpKzna7/K/pyXBLIz1iR/3SeyaW flFr8qPIoka7qnf8hp5LrjE6S2eOWNwamWqEMUQLSwkL2gdT/4L/daScjv7etAjfNTQu KptJxUNPTSd73NP02Zo8mlgJNuvc//Sz22stvSeBLz2FpWXVoLHWWTkaMbsWQJ8RaNrd 5R9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=eGGuz2nfTPciuFQPCoM9JMqK9sEvslMSDeGBVtiG3x8=; b=I9nctC7Ch0Gk3nR35BopR2PohUQXUEVIe4d1fgVxidf432PPKQCKCG+MGJ9mRSvUeM 6GvhjzOCveY6YAifvoQcZCalOP3fMXtqzv1IUN+IwfSXSWmqqHOjA1ZOuin/L8YPkD3n 3RxPMfSLDX87SoPbSZoanLiGDww97wSE/7RRZbVotWqwQE3EglI6JJ1SfLsn9nhytLCy BPY5ninYvGTDpJ3zO8U/mlQJzRm6xJ1jfjOzSHBwRKPpmu6m3c2NHJzo/rhZW8n643kM 1wHxhKsLEa5dMEWeQaHdVfw17Rd1ci8GX240bhnkrrIysZ03FJVCO3VvazsY1UEeCvuZ bunQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ltKSRXM+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j26si20271379eds.457.2020.12.28.06.20.15; Mon, 28 Dec 2020 06:20:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ltKSRXM+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2441535AbgL1OSG (ORCPT + 99 others); Mon, 28 Dec 2020 09:18:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:53160 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2501920AbgL1OSE (ORCPT ); Mon, 28 Dec 2020 09:18:04 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id DC5F620791; Mon, 28 Dec 2020 14:17:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1609165044; bh=PwOG6pmQlyMhOuTGnEIoMhyMbWfKZeMtPuu38FTi1x8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ltKSRXM+T3vWMAyJmLgkK/pEQK3U81QLE/6ByWrWXBcgMxD1v0PwQcKi3DtYDtjVz lFt4//MzeELB3ZESapXE6rmm81bAsp8wnzMrAl5LaO3LH7F4pu20m29Zy8NmnPOgO8 2GuoDN4+xEG33OhZniDLDbF8up3Csw8wOxbK2ClY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sean Nyekjaer , Sriram Dash , Dan Murphy , Marc Kleine-Budde , Sasha Levin Subject: [PATCH 5.10 391/717] can: m_can: m_can_config_endisable(): remove double clearing of clock stop request bit Date: Mon, 28 Dec 2020 13:46:29 +0100 Message-Id: <20201228125039.739150897@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201228125020.963311703@linuxfoundation.org> References: <20201228125020.963311703@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sean Nyekjaer [ Upstream commit c9f4cad6cdfe350ce2637e57f7f2aa7ff326bcc6 ] The CSR bit is already cleared when arriving here so remove this section of duplicate code. The registers set in m_can_config_endisable() is set to same exact values as before this patch. Signed-off-by: Sean Nyekjaer Acked-by: Sriram Dash Acked-by: Dan Murphy Link: https://lore.kernel.org/r/20191211063227.84259-1-sean@geanix.com Fixes: f524f829b75a ("can: m_can: Create a m_can platform framework") Signed-off-by: Marc Kleine-Budde Signed-off-by: Sasha Levin --- drivers/net/can/m_can/m_can.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index 61a93b1920379..7fc4ac1582afc 100644 --- a/drivers/net/can/m_can/m_can.c +++ b/drivers/net/can/m_can/m_can.c @@ -380,10 +380,6 @@ void m_can_config_endisable(struct m_can_classdev *cdev, bool enable) cccr &= ~CCCR_CSR; if (enable) { - /* Clear the Clock stop request if it was set */ - if (cccr & CCCR_CSR) - cccr &= ~CCCR_CSR; - /* enable m_can configuration */ m_can_write(cdev, M_CAN_CCCR, cccr | CCCR_INIT); udelay(5); -- 2.27.0