Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751032AbWIFRlo (ORCPT ); Wed, 6 Sep 2006 13:41:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751094AbWIFRlo (ORCPT ); Wed, 6 Sep 2006 13:41:44 -0400 Received: from brick.kernel.dk ([62.242.22.158]:30295 "EHLO kernel.dk") by vger.kernel.org with ESMTP id S1751032AbWIFRlm (ORCPT ); Wed, 6 Sep 2006 13:41:42 -0400 Date: Wed, 6 Sep 2006 19:45:01 +0200 From: Jens Axboe To: Erik Mouw Cc: Peter Zijlstra , linux-mm@kvack.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Daniel Phillips , Rik van Riel , David Miller , Andrew Morton , Pavel Machek Subject: Re: [PATCH 11/21] nbd: limit blk_queue Message-ID: <20060906174500.GK14565@kernel.dk> References: <20060906131630.793619000@chello.nl>> <20060906133954.845224000@chello.nl> <20060906151716.GG16721@harddisk-recovery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060906151716.GG16721@harddisk-recovery.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 773 Lines: 20 On Wed, Sep 06 2006, Erik Mouw wrote: > On Wed, Sep 06, 2006 at 03:16:41PM +0200, Peter Zijlstra wrote: > > - disk->queue = blk_init_queue(do_nbd_request, &nbd_lock); > > + disk->queue = blk_init_queue_node_elv(do_nbd_request, > > + &nbd_lock, -1, "noop"); > > So what happens if the noop scheduler isn't compiled into the kernel? You can't de-select noop, so that cannot happen. But the point is valid for other choices of io schedulers, which is another reason why this _elv api addition is a bad idea. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/