Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp9106863pxu; Mon, 28 Dec 2020 06:49:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJzsR/Tw4mYHoEB+l8OglK4VmcYt4KlfBFh8ifvtJvQGfT8R0ElcjWwBxgYY42Nb1MJ96KM4 X-Received: by 2002:a50:f404:: with SMTP id r4mr42429550edm.62.1609166946297; Mon, 28 Dec 2020 06:49:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609166946; cv=none; d=google.com; s=arc-20160816; b=LSlC+jGUUfzavCPg3QEoQ2EZTF7UwE9LDD/xh8orL3Ge/AOGNGjX4avOx310Kfyr4i iE4P1NUaZgzIM+MFD3lQyPCxnRAaXwf8H3Ulo4VsVFSvV8t7263ZvqZk9jM4Atu4gXxd u1Fpx8wnVmT5KTHf2SelQkXZ8kn49lxd8XRCoyB7gpHlsuEp2/mGamFtRJ9WCg6fxNCD qcuacfTmB6toOYOreDcxUKFlYvCLjta+qF+LujjMJmUSqCSXIWrR/cI4QCuTxRjwNt3/ F9y+1P/X4jH0a7xxeCIM8tEMUK1TEMrcuFdl6rahMpm/qsk2+wTGfEjCFTvCyLPDfZLv gmRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=W0CfKaqx1PQ3awOxr7rplyqEHxsYKIuCxU0sPJYBSyk=; b=Vuk8DOQdF+JwP53jJ9yd3V+FtSsXC1FA12IUC9A+udk6quZ2O48zLZUsyc9P5VvnJF k9r4fCUj/+09XpDYh2N1o6AlUho8krHgmMg2U2lJX2m8royamqIjlVjnbftR7C+8/2Fm 2QBWOEBv5C9gciKQQw6G+L0Jr/RCNT2AuZEG4GpMRTZCiHLZenAdQ0yY3JFMj2hVrryN dTrxdd4DU4ZAv5zEKeLxDDreWAPLW26+H2l39fA4WGCIOgouv0pa+npxZoOSjMTcaRnc NtunPqJbswZTs6tCHeZNVE5Bolgl6n9clxuZ/0Nwrf2mMd7GWetPS1xB0K+5jimQtNen ssCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=RQg2G0Ug; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id zh18si18947329ejb.624.2020.12.28.06.48.43; Mon, 28 Dec 2020 06:49:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=RQg2G0Ug; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2506454AbgL1Ope (ORCPT + 99 others); Mon, 28 Dec 2020 09:45:34 -0500 Received: from mail.kernel.org ([198.145.29.99]:60270 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2503078AbgL1OYa (ORCPT ); Mon, 28 Dec 2020 09:24:30 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id C5EA920791; Mon, 28 Dec 2020 14:24:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1609165454; bh=yL8ZHZoVvO8rzAeXC+96qAJNaHQRNIO6xL/3dhCPU7c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RQg2G0UgKNQW2G61yg2mMgmKFA0PyozmtEIHm4W+Po3Gac4wCZCRpVxYp6GuLsxwa V4yYIkmRqZbiISF2Jijnlfw23l+YoJu9Yy2Vw3FWR/s5/hppHR0HywMTGmQMnU8qaV D3KKJEvNyRfbHTP7ARX92+eMS/jtdihOr/Pfv9AU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hui Wang , Takashi Iwai Subject: [PATCH 5.10 537/717] ALSA: hda/realtek: make bass spk volume adjustable on a yoga laptop Date: Mon, 28 Dec 2020 13:48:55 +0100 Message-Id: <20201228125046.693352487@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201228125020.963311703@linuxfoundation.org> References: <20201228125020.963311703@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hui Wang commit c72b9bfe0f914639cc475585f45722a3eb57a56d upstream. This change could fix 2 issues on this machine: - the bass speaker's output volume can't be adjusted, that is because the bass speaker is routed to the DAC (Nid 0x6) which has no volume control. - after plugging a headset with vol+, vol- and pause buttons on it, press those buttons, nothing happens, this means those buttons don't work at all. This machine has alc287 codec, need to add the codec id to the disable/enable_headset_jack_key(), then the headset button could work. The quirk of ALC285_FIXUP_THINKPAD_HEADSET_JACK could fix both of these 2 issues. Cc: Signed-off-by: Hui Wang Link: https://lore.kernel.org/r/20201205051130.8122-1-hui.wang@canonical.com Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/patch_realtek.c | 7 +++++++ 1 file changed, 7 insertions(+) --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -3104,6 +3104,7 @@ static void alc_disable_headset_jack_key case 0x10ec0215: case 0x10ec0225: case 0x10ec0285: + case 0x10ec0287: case 0x10ec0295: case 0x10ec0289: case 0x10ec0299: @@ -3130,6 +3131,7 @@ static void alc_enable_headset_jack_key( case 0x10ec0215: case 0x10ec0225: case 0x10ec0285: + case 0x10ec0287: case 0x10ec0295: case 0x10ec0289: case 0x10ec0299: @@ -8578,6 +8580,11 @@ static const struct snd_hda_pin_quirk al {0x14, 0x90170110}, {0x19, 0x04a11040}, {0x21, 0x04211020}), + SND_HDA_PIN_QUIRK(0x10ec0287, 0x17aa, "Lenovo", ALC285_FIXUP_THINKPAD_HEADSET_JACK, + {0x14, 0x90170110}, + {0x17, 0x90170111}, + {0x19, 0x03a11030}, + {0x21, 0x03211020}), SND_HDA_PIN_QUIRK(0x10ec0286, 0x1025, "Acer", ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE, {0x12, 0x90a60130}, {0x17, 0x90170110},