Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp9116325pxu; Mon, 28 Dec 2020 07:03:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJx47NXgjHdOulPeScFuznhakFmUUsxGNv1+ymQvHOe45+eFcP849f5EyVeDVpxpZQ8Pp5ob X-Received: by 2002:aa7:c886:: with SMTP id p6mr43474907eds.352.1609167827176; Mon, 28 Dec 2020 07:03:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609167827; cv=none; d=google.com; s=arc-20160816; b=vyIhfWOKR02uemBCRvoK5I4xvuYEiZsaFL4cHDv6rzaui/39/UFiCQ4hx0G805ipyU QKKcjVJBeFQGwObwBaQlMvsIf/ezBp47fUXe8rVQuu3FwStOUJgFNoDVeslaeLClAycj cJ1nAf3KK6QMmrxxuBchOB22hd3pnAmZur3sWQWG4yRjrN23vYvQNurvWu51xC85S4m/ 2v5gdpGFPt+eLsUKyZ4YUP0Dbg1jU0kpFgoJhddvXsVbSfFxmSI0hMJI2p9nIcfbPOJX TVDlyVhBuVCoE/K3MXW/cA6EQvxOBxqFkgk2JlVP2aosvo7fP8j1wu6DLeqccpi38LNA JOpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=rr1YLILqYzDdsjPxMKnVBLXVTxZ8gEPQNN3L2FknxhQ=; b=hNvJqaOgZLMfmlQZbJowr839PiMxOx7wKQ6G7OeuUSQXWdxJz1j+ygTmNVwpPdJIKZ EnM/+99iqQtvs6tgw/G2nZ8UFDpE1qze3ev/i4A0LtZIt+/WrLWFh8EwyEDK8qJLIrLW i3A7Zdg82kNHz/TuOEKhGPG04u/M1D0xCnofISU0fxbAiUjrc/PamXLEmcjNab7K2LHc ahsoZ1ubirRBMUE+RPBHCyrDorf5AnQjd0gFWoHpUsIp+h9crBWToF8zOsAvYG5Q6z6Y ckSD74gT7nJX0MDFcsYv40gQOgtKO3KKULiCjrrkV/Vp6qVt0UaEHbyEcEaKJR1vDB+n ZJww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=lI+RFie+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v19si20470786edr.303.2020.12.28.07.03.23; Mon, 28 Dec 2020 07:03:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=lI+RFie+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439301AbgL1PB2 (ORCPT + 99 others); Mon, 28 Dec 2020 10:01:28 -0500 Received: from mail.kernel.org ([198.145.29.99]:54278 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392591AbgL1PBF (ORCPT ); Mon, 28 Dec 2020 10:01:05 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id C2554208D5; Mon, 28 Dec 2020 15:00:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1609167624; bh=TbqSh3PsttugZzWTBvvrutqtvAnSYnz4ZADL+W5fc8Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lI+RFie+AwGXRUGcVCg34DyxSiywWTGmJbCDOPrDP5vUUpiIcQlsA2HCUo0m4U0kO XQBWUcYELkfwLW4h9yePXnT7ad6flrv2/PF3crl10sKdcIXKj9iieS7Hr9sPVDtyNR pai6a9dUmOmfZ6bDFJJhqtvoWVZu/RNN4Qa+GLjI= Date: Mon, 28 Dec 2020 16:01:46 +0100 From: Greg Kroah-Hartman To: Jerome Brunet Cc: Felipe Balbi , Ruslan Bilovol , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] usb: gadget: u_audio: remove struct uac_req Message-ID: References: <20201221173531.215169-1-jbrunet@baylibre.com> <20201221173531.215169-4-jbrunet@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201221173531.215169-4-jbrunet@baylibre.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 21, 2020 at 06:35:30PM +0100, Jerome Brunet wrote: > 'struct uac_req' purpose is to link 'struct usb_request' to the > corresponding 'struct uac_rtd_params'. However member req is never > used. Using the context of the usb request, we can keep track of the > corresponding 'struct uac_rtd_params' just as well, without allocating > extra memory. > > Signed-off-by: Jerome Brunet > --- > drivers/usb/gadget/function/u_audio.c | 58 ++++++++++++--------------- > 1 file changed, 26 insertions(+), 32 deletions(-) This patch doesn't apply, so I can't apply patches 3 or 4 of this series :( Can you rebase against my usb-testing branch and resend? thanks, greg k-h