Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp9120564pxu; Mon, 28 Dec 2020 07:08:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJzhVvYSaHpooSdNPzSU/XY+afWHl/LfJER9rEBTPxllen2LRii6CD438adFpzs0u1EVoF6v X-Received: by 2002:a17:906:af75:: with SMTP id os21mr42545611ejb.330.1609168106817; Mon, 28 Dec 2020 07:08:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609168106; cv=none; d=google.com; s=arc-20160816; b=m4G68fQjDv7oHM3ESmJyGliiTIh9bnX6Fd4rqe+wff6DDYPoNfQ89dgIzdSAncr4kS wJHyCpijWoQuPWEyNQ8T/fhAX8RKcuBflGxUOrJ3pmAvBboA9IETg5Q5nRDg8l5+9hY9 WvfvrAGwudLwrXDGyLu45QFEDNDbrEi9L2ym5Lokzg8j3//Q5xjUW96eJbc6ej1aphvJ G7uIXpRLQdAKGL5C97zwe5picQT/xS2ciVV1uQOD6nKGHiynN2jjfe7o4gcugEgdx8QT 1NcjdR5giaahCK+JYubAgnEzmYSNomltmz/FiFo25mbquXtTqwokftPq3tp80BbSKECk eMZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=p8z4xnepYR/ZvhsDJf3v7gGBWpUpr6+LjCXlbRmOGuk=; b=jHfrxRY7qRZZqKlkBJ1N6B72gUUX3Zxsp+9gdf+5Zo/FPOUlZQAFApeN+oEPDv7gno /VSAagrPdf/SuM6JRSLOSXjPL6efnXB/Ivvr3sNNgGlvdBUqo3a43cdL0HimvZ1STeoR OPP0Sqdc1wR8d8d+OaM65uebUCnh00uomjkJelISjk7Ilw/4EGcVzkuRIQ5pNAZCh536 hVCmLZzn8pbmvMC4VwNX3s83/ErLEwCaZ8/Yo5mz8P+6TLymZDFbTRvpm1WgU4y3b/It gQPq/MflByDVzhDHXNUkJyLjOiDfYAdorLuZ+PMqeOtsja7rWTcrAv9bx/A9OiGDS1bg 2M+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=U1mGSnwz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lw15si18842132ejb.535.2020.12.28.07.08.00; Mon, 28 Dec 2020 07:08:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=U1mGSnwz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439476AbgL1PFD (ORCPT + 99 others); Mon, 28 Dec 2020 10:05:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:45648 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2439587AbgL1OLT (ORCPT ); Mon, 28 Dec 2020 09:11:19 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id F3641206E5; Mon, 28 Dec 2020 14:11:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1609164664; bh=6qwQLglfgXiG6hIKLfhI7to85cgl1rUQfGBaxBlH7c4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U1mGSnwzZraGv6GlB+dKDnATIyjPYbs/MKgOrSWpl//MNhKg2VpZ7st9RrfnllJVJ 4XMxWrNHdhvT9Lv2GzJUEZHFeZLJ0mJ9aJpEEgQfnEqxGlO9xeRx7GDVTRUa9z50+u j/yjZWIQb4WuUWZeRJE12UEtVWjUDizX1O6CUqnw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Qinglang Miao , Mario Limonciello , Hans de Goede , Sasha Levin Subject: [PATCH 5.10 255/717] platform/x86: dell-smbios-base: Fix error return code in dell_smbios_init Date: Mon, 28 Dec 2020 13:44:13 +0100 Message-Id: <20201228125033.205917753@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201228125020.963311703@linuxfoundation.org> References: <20201228125020.963311703@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Qinglang Miao [ Upstream commit 2425ccd30fd78ce35237350fe8baac31dc18bd45 ] Fix to return the error code -ENODEV when fails to init wmi and smm. Fixes: 41e36f2f85af ("platform/x86: dell-smbios: Link all dell-smbios-* modules together") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao Reviewed-by: Mario Limonciello Link: https://lore.kernel.org/r/20201125065032.154125-1-miaoqinglang@huawei.com Signed-off-by: Hans de Goede Signed-off-by: Sasha Levin --- drivers/platform/x86/dell-smbios-base.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/dell-smbios-base.c b/drivers/platform/x86/dell-smbios-base.c index 2e2cd565926aa..3a1dbf1994413 100644 --- a/drivers/platform/x86/dell-smbios-base.c +++ b/drivers/platform/x86/dell-smbios-base.c @@ -594,6 +594,7 @@ static int __init dell_smbios_init(void) if (wmi && smm) { pr_err("No SMBIOS backends available (wmi: %d, smm: %d)\n", wmi, smm); + ret = -ENODEV; goto fail_create_group; } -- 2.27.0