Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp9129350pxu; Mon, 28 Dec 2020 07:20:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJzbO4N+772eMzKnUga6DINGNC2EfYeMDCRZ6VZus219kQG2PvCYlujs2zijZq1IVi1t2MZz X-Received: by 2002:a05:6402:b88:: with SMTP id cf8mr43643999edb.140.1609168817125; Mon, 28 Dec 2020 07:20:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609168817; cv=none; d=google.com; s=arc-20160816; b=jNvGUO1SMAYX4bIZlDz4EHd/dVgSsVNrGtMz3ywDNV4ZFLH7vqys6sRO5tS/QxrUGV m1yNnBzXS6+3WFnvGMwdJLra5v/no5KTzu+s45/6D1XKfgqwrFpKEge/azIXfhAT3zNy 2uMVKMYVrWIGMRIQsN5gVubOucppyau3Fo78LEPwKe+bxlNAppJob4M7Hdhlk4fbe0fO DRDl/Cm10Cszr9fwfyebnqiDp3Hjv7Rvrg13u1m88KNdeJXekDN4Kw6Q7fyXVw1YFT4a Ju8hXE0K786tP+lRynrfR2ttq0vtBKT9FMPOO5eO/6Ra0vWqqPxZLH+DVuxMLluYHJ1p oZzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=K1d1nvywgg8FIlaWmeKQKgJO8bGGb24wj86pSpFrsMo=; b=g6hHOZuj2e0u8wZzxt5xeMyt7PaV/0VWuxxytndvhbyMkkhf1vEogSNUC7QzrfkKHB 8NIRLgkhUNZHD2nGcG8A+jBZIGbjM9W0j5LGJgGrGzvcRHFN2SUPH2UY//UEHHvQR/Qm rYprm3jWpVvpPGdYpksnkKlYW/VX6ECFxRqR7x9m0nAE5NHHRDhIWJCU81kvKkURPIek ltD+ZS8nsff3nSSjRuHjgvRnWdtK+x+SqaBdv2merYlZnYWI7z6YXkWq9+8yGK7Y5Ixt 8Li6AmP8Njm1mFFRqOIYbyuxJ3qcjOjITHcLp9HgtWuJpfnckBX10VOplgstjUWm/7kJ VuSw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="GcpT/gBG"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 18si10590036eju.589.2020.12.28.07.19.53; Mon, 28 Dec 2020 07:20:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="GcpT/gBG"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437450AbgL1OEn (ORCPT + 99 others); Mon, 28 Dec 2020 09:04:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:38884 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437409AbgL1OEh (ORCPT ); Mon, 28 Dec 2020 09:04:37 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8C73A208B3; Mon, 28 Dec 2020 14:03:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1609164237; bh=/UCeK+RBm52jb11IhPukcWhtSiwMlu0vOcoN6f5hhSE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GcpT/gBGo4PovvI+berhVVP6d+EJ//3TWW/EKRV6yIzGTfXmZPfZVHA/Y9sP+01WI DWu9XZuaeBKjAp/9OwUcn9Og1+VsTu1f4JKrh1WevZZF/RhDfjpU40pPlbMMoJpT1f wb8BM6KPDpWHH3hTeS27iV7lERa96iTBtwee3iZg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Zhang Qilong , Mark Brown , Sasha Levin Subject: [PATCH 5.10 079/717] spi: tegra20-sflash: fix reference leak in tegra_sflash_resume Date: Mon, 28 Dec 2020 13:41:17 +0100 Message-Id: <20201228125024.772172680@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201228125020.963311703@linuxfoundation.org> References: <20201228125020.963311703@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zhang Qilong [ Upstream commit 3482e797ab688da6703fe18d8bad52f94199f4f2 ] pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to pm_runtime_put_noidle will result in reference leak in tegra_sflash_resume, so we should fix it. Fixes: 8528547bcc336 ("spi: tegra: add spi driver for sflash controller") Signed-off-by: Zhang Qilong Link: https://lore.kernel.org/r/20201103141323.5841-1-zhangqilong3@huawei.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spi-tegra20-sflash.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi-tegra20-sflash.c b/drivers/spi/spi-tegra20-sflash.c index b59015c7c8a80..cfb7de7379376 100644 --- a/drivers/spi/spi-tegra20-sflash.c +++ b/drivers/spi/spi-tegra20-sflash.c @@ -552,6 +552,7 @@ static int tegra_sflash_resume(struct device *dev) ret = pm_runtime_get_sync(dev); if (ret < 0) { + pm_runtime_put_noidle(dev); dev_err(dev, "pm runtime failed, e = %d\n", ret); return ret; } -- 2.27.0