Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp9132657pxu; Mon, 28 Dec 2020 07:25:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJx3hC0Cr/Wd3jmyOftB1IavyDRtjBKljvUO3qv9XuXS+IrO+9VDQr+9C7j/9haTokGwgzYU X-Received: by 2002:a17:906:3881:: with SMTP id q1mr42958496ejd.490.1609169142294; Mon, 28 Dec 2020 07:25:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609169142; cv=none; d=google.com; s=arc-20160816; b=X1KwPCkakhPrFze/7zbgKMIsI+sGNB2Lht7ixlCnqU7T3nt8NrP9LQ8q5aapxKvYbL YHZddDFV3Cw/SE3EeTibJYpOfcprhnkStk9iU3U7sgWpsu1O3d8ysUP6xiSS/R4LgN2W oGwySbJs8zX0McenbZsqXp3MLJGNWERWT1EDR7TaSUU8hv0UhdNwzpUCK/icFI2kRYjw YxhrjU+PdIosJ/ym8Ek4sl9SHntqSI19D8F+Mwc1zRDiTxLdsFD/Du0cwDfFlvHS1d1T UJO4kFffKMnCtm+hTGQlIIrRmryieJUbCmHlL8T3dwXmdALXQy8P1zfM3/FSJnZ9eAN3 Y7Gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=gNPnq43UHU/2AQwIoGDHDQAIpRdZ6NAq6zFYXlHhnFQ=; b=YM10aUHuZqpLqRovrMF+544rGD24lk/AGaOYJrjKTVKE8bD0wsxY/s/qO9TtqfisMN 6ZM65dm6P8smv1w0wBApt7XKz7BEtGDSL90vVvxkJ8bkHWSMrjjxSpG8rfSjAvZIhqqc hgxtdEk+cmtnjf09eoVCBNU9z4CAbfguaELJgXdnHbp30rExYts2XTgacgTnmdwwpsrL oRhnnJM1oLN/rnXAtLAgGHV2bwbTN1/Ix+QnkI9JW8J8t8NaN9gN94GYzUWPX4RNrN/c cvWqQcftlgLyAvHQhrRK0RixyhuY/zn8jESZbs2V+IbJk5qRspwKQyVH4M9XgwHD3zdr NZww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=kosommWB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hh2si18885092ejb.627.2020.12.28.07.25.18; Mon, 28 Dec 2020 07:25:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=kosommWB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439917AbgL1PXS (ORCPT + 99 others); Mon, 28 Dec 2020 10:23:18 -0500 Received: from mail.kernel.org ([198.145.29.99]:35320 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2408350AbgL1OB2 (ORCPT ); Mon, 28 Dec 2020 09:01:28 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0889720791; Mon, 28 Dec 2020 14:00:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1609164047; bh=07j3CHMHEV0PN0KIwcfkIf3mbpYANAr2zUl3TJdgCcs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kosommWBlLXaYWHepq4nA5tQrW8OReMftGo5uOxTStm+eSTXs51RNRX7835c1O5eQ OTwixdDHjqEtvpSiQMZdVWxC/tdMOXpd9LTpb0pdmN8cdfPPxuRStsG7qvgTXoN7HS tDy+MI5dFjXyHtINuyosxGt/gu7mVZEv+hLSI30w= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Harry Wentland , Arnd Bergmann , Alex Deucher , Sasha Levin Subject: [PATCH 5.10 040/717] drm/amdgpu: fix build_coefficients() argument Date: Mon, 28 Dec 2020 13:40:38 +0100 Message-Id: <20201228125022.907527389@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201228125020.963311703@linuxfoundation.org> References: <20201228125020.963311703@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann [ Upstream commit dbb60031dd0c2b85f10ce4c12ae604c28d3aaca4 ] gcc -Wextra warns about a function taking an enum argument being called with a bool: drivers/gpu/drm/amd/amdgpu/../display/modules/color/color_gamma.c: In function 'apply_degamma_for_user_regamma': drivers/gpu/drm/amd/amdgpu/../display/modules/color/color_gamma.c:1617:29: warning: implicit conversion from 'enum ' to 'enum dc_transfer_func_predefined' [-Wenum-conversion] 1617 | build_coefficients(&coeff, true); It appears that a patch was added using the old calling conventions after the type was changed, and the value should actually be 0 (TRANSFER_FUNCTION_SRGB) here instead of 1 (true). Fixes: 55a01d4023ce ("drm/amd/display: Add user_regamma to color module") Reviewed-by: Harry Wentland Signed-off-by: Arnd Bergmann Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/display/modules/color/color_gamma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/modules/color/color_gamma.c b/drivers/gpu/drm/amd/display/modules/color/color_gamma.c index b8695660b480e..09bc2c249e1af 100644 --- a/drivers/gpu/drm/amd/display/modules/color/color_gamma.c +++ b/drivers/gpu/drm/amd/display/modules/color/color_gamma.c @@ -1614,7 +1614,7 @@ static void apply_degamma_for_user_regamma(struct pwl_float_data_ex *rgb_regamma struct pwl_float_data_ex *rgb = rgb_regamma; const struct hw_x_point *coord_x = coordinates_x; - build_coefficients(&coeff, true); + build_coefficients(&coeff, TRANSFER_FUNCTION_SRGB); i = 0; while (i != hw_points_num + 1) { -- 2.27.0