Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1608762196-29871-1-git-send-email-tharvey@gateworks.com> <20201224112335.GA15628@kozik-lap>
In-Reply-To: <20201224112335.GA15628@kozik-lap>
From:   Tim Harvey <tharvey@gateworks.com>
Date:   Mon, 28 Dec 2020 08:18:17 -0800
Message-ID: <CAJ+vNU0cEvMMFQXmO9KOG3WR4Cu1E+o1XSWv8xx35ALeZ=pzzg@mail.gmail.com>
Subject: Re: [PATCH 1/2] dt-bindings: arm: fsl: Add binding for Gateworks
 boards with IMX8MM
To:     Krzysztof Kozlowski <krzk@kernel.org>
Cc:     Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Device Tree Mailing List <devicetree@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Dec 24, 2020 at 3:23 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Wed, Dec 23, 2020 at 02:23:15PM -0800, Tim Harvey wrote:
> > Add bindings for the Gateworks Venice Development kit boards with
> > IMX8MM System on Module.
> >
> > Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> > ---
> >  Documentation/devicetree/bindings/arm/fsl.yaml | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > index 1ca9dfa..705c6e8 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > @@ -405,6 +405,9 @@ properties:
> >                - beacon,imx8mm-beacon-kit  # i.MX8MM Beacon Development Kit
> >                - fsl,imx8mm-ddr4-evk       # i.MX8MM DDR4 EVK Board
> >                - fsl,imx8mm-evk            # i.MX8MM EVK Board
> > +              - gw,imx8mm-gw71xx-0x       # i.MX8MM Gateworks Development Kit
> > +              - gw,imx8mm-gw72xx-0x       # i.MX8MM Gateworks Development Kit
> > +              - gw,imx8mm-gw73xx-0x       # i.MX8MM Gateworks Development Kit
>
> I think you should skip the wildcards in compatible and choose one
> specific compatible. What if at some point you would like to add gw,imx8mm-gw7113-0x?
>

Krzysztof,

Thanks for the review. I do want the wildcards as above because they
represent model variations that do not affect device-tree such as
component subloads.

Thanks,

Tim