Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp9174277pxu; Mon, 28 Dec 2020 08:25:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJyFBiN6mCuM+mgI8HyduvLX1cBI0jgtMaPyYMVEv6JDw50EYL7bQ7YuOHQYOMyasNrXd8Ji X-Received: by 2002:a50:c209:: with SMTP id n9mr42666021edf.123.1609172719041; Mon, 28 Dec 2020 08:25:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609172719; cv=none; d=google.com; s=arc-20160816; b=Kr8OdaLkJ66ia+435D8BbEbr5vVjUpCFFyQZ77dTuXu3CaR2DUOKQz1eSts7/I4hsx sVlBZEsGfgn2KHQQ7AzFpF9Q+HsTc+DOAnbI+I47QwRR8WywTt3IBjqakdDT3HoIa5TB hioQLulHWuiZTi/NJYyohgdlYXcXa4zcXV7lS8ZdHw4JuALNEsLKShH626I4URxv0Gvo 0b68oGtK3Bq2jt77ViMtw3F/x7x/DX6Bt7BgLvBj0sA8ZRhaDDLyD0j1IgDG4gB253PZ kp1yda+7KFOA9sAqlLH0l6TNFBGdQbuyO6dEdIGHAy4/qUF1uFzLz5ltc+1s3f1A0uOh Sa8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=OUbRB1iLxv4OWsvTyCVPd4R/0rCqaIC4yP0OSZ5OHbU=; b=qADqmASh421wt7OsulzSFkAwA+y5u7RQ/8s08WKg9pgaXNrk2j7w2XRUAvn9PAIPpi HKcs7fnzmWSXoGOdjNMpU1ucHvtbChtvfEsI0jdKmDqZMCGMgApp5Y3BH6cTKJrT9H8+ HgfowpWJFKlvwZ9ZHow+Kno6rkME+tbxlufZ7+bI50qXUhlAgVsO6li5VgALRiW2csXO s9eHs2Zcwhrg4RiB8iRrUbiDuwaSlwSmQxua9lheiFjB1cmHXE0gpctGaba7tOBTvU9Y An4YoH7l8yV+TcWOfDBjaW7wXUiceQh7pfsNHciEp2KzAa/krY8os52VUedQ9PoQlL23 c7MQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="cOtF0a/9"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l6si18971431ejp.140.2020.12.28.08.24.56; Mon, 28 Dec 2020 08:25:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="cOtF0a/9"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731884AbgL1NLz (ORCPT + 99 others); Mon, 28 Dec 2020 08:11:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:38780 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731657AbgL1NLR (ORCPT ); Mon, 28 Dec 2020 08:11:17 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 22C8C20776; Mon, 28 Dec 2020 13:11:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1609161061; bh=KEl7a0v7/VsWcOnw1uYWHi/NQyARYMBIfAdhmwLWU78=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cOtF0a/974/1t8hN3YxCRv0WJDtUeYTUts4ftM47UFBNPRuN/yC4+OCQkmrSNSA71 ZHZ3+Mm4QS7RNAu7T4eaI0QaHKZUetJZbLffmfW5guouhYFpUzqpo3ysq5GyA7nBI9 Mp/tJgbDnXMOk/2cG/F4vAmYyMODFo1bOGBV9904= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Vincent Bernat , Jakub Kicinski , Sasha Levin Subject: [PATCH 4.14 088/242] net: evaluate net.ipv4.conf.all.proxy_arp_pvlan Date: Mon, 28 Dec 2020 13:48:13 +0100 Message-Id: <20201228124909.029415053@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201228124904.654293249@linuxfoundation.org> References: <20201228124904.654293249@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vincent Bernat [ Upstream commit 1af5318c00a8acc33a90537af49b3f23f72a2c4b ] Introduced in 65324144b50b, the "proxy_arp_vlan" sysctl is a per-interface sysctl to tune proxy ARP support for private VLANs. While the "all" variant is exposed, it was a noop and never evaluated. We use the usual "or" logic for this kind of sysctls. Fixes: 65324144b50b ("net: RFC3069, private VLAN proxy arp support") Signed-off-by: Vincent Bernat Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- include/linux/inetdevice.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/inetdevice.h b/include/linux/inetdevice.h index ff876bf66cf25..52e1230cfe1b4 100644 --- a/include/linux/inetdevice.h +++ b/include/linux/inetdevice.h @@ -102,7 +102,7 @@ static inline void ipv4_devconf_setall(struct in_device *in_dev) #define IN_DEV_LOG_MARTIANS(in_dev) IN_DEV_ORCONF((in_dev), LOG_MARTIANS) #define IN_DEV_PROXY_ARP(in_dev) IN_DEV_ORCONF((in_dev), PROXY_ARP) -#define IN_DEV_PROXY_ARP_PVLAN(in_dev) IN_DEV_CONF_GET(in_dev, PROXY_ARP_PVLAN) +#define IN_DEV_PROXY_ARP_PVLAN(in_dev) IN_DEV_ORCONF((in_dev), PROXY_ARP_PVLAN) #define IN_DEV_SHARED_MEDIA(in_dev) IN_DEV_ORCONF((in_dev), SHARED_MEDIA) #define IN_DEV_TX_REDIRECTS(in_dev) IN_DEV_ORCONF((in_dev), SEND_REDIRECTS) #define IN_DEV_SEC_REDIRECTS(in_dev) IN_DEV_ORCONF((in_dev), \ -- 2.27.0