Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp9175573pxu; Mon, 28 Dec 2020 08:27:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJwtSjQ4wJ/9oYyTC0kfZuaScAqJE1ng9e97ik+DUbXDI/tTnyEh2DNDFH6VWF+6Cy86xlWE X-Received: by 2002:a50:ed04:: with SMTP id j4mr43725185eds.84.1609172842876; Mon, 28 Dec 2020 08:27:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609172842; cv=none; d=google.com; s=arc-20160816; b=F10EJi4Fx483OdOPjvI2B7gtAS8dmelmw1sp96y0ydf6jwQo7pC47Mj7umNhTg4Bga W4cWYBEFfW4znonuFEdmJLTWnKgHfVxmxjLSxayupXHuLxPJdgDs00/1SK5NtP/aI05z OhVCU5WxIF8zu2zSf27kNehoIjlZC4KNkltsf51cCpf7H05+EXEuGp+3IVE/EPsD4Gyv g9p7tRccQ2cO2DzHLfpKRjIHWheeAraN9y5A2/xfhAo++0KcIM9mknIFxkyoZHakImNo 06i+79Jxefcqcnvab3SFQwdgVLMyRUCd//VhAObrrtql3S4JBQgV9Zv7blh6mSMJjMpm FWpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=8Jdr706AjbuEDThqdkBZ1/ILqK4io5LQF6e6wop2leU=; b=R0FP6FeBu7HheS5i83frqJB40LVExq//UjyC+urzp3oUm46MgqP7mkPY9tQkYvVDWh EEbqL64qp11c3S6b/CzRfV0GgkTmfkgAOSVuWCI/J/3hjL9YBkvLAGIPe8GbwQkxB8yu 7Qi6kXWBxXfrxhYJ6LdBUscZiYIAGiSD1H5PvppyCUXZxs9KjlxeGw71MZsmCm9/BLRh OQSWr4Kpqr6DktULmdQUBe7zWRnFAyKUyj0mmu5lXXJkRwiWdFzuvqez1LVBrR6ya0rm xDcbLSUxC9/cbgUjP9FLi78nUxqJ6T8S40cmOT/04PUxUkHKZztFYRN3i3pmUlJT8QRf 21xg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ZRVtBS5Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m26si24353075edp.209.2020.12.28.08.26.59; Mon, 28 Dec 2020 08:27:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ZRVtBS5Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2440988AbgL1QYq (ORCPT + 99 others); Mon, 28 Dec 2020 11:24:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:37920 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731296AbgL1NKI (ORCPT ); Mon, 28 Dec 2020 08:10:08 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 203EF22B3A; Mon, 28 Dec 2020 13:09:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1609160967; bh=1DKUcyuuGjk0ZLK2zckVHV4YP3EywcRPMhynTZVpuFY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZRVtBS5ZR5VESzxGlKp+v4tGa08pPqac+9Vp9SVAqusk8o8lj+TvEV51TwRVOKZse 2lLy9GtknlT1MBw6MxajcVHMOf0/6/6dptv9NaF6GfICziGdnsq7NMY0dwcAv/jIof YRCgo6YXsOVznFT7+/OzXgyjezOz5Uvw307uyQEA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Krzysztof Kozlowski , Gabriel Ribba Esteva Subject: [PATCH 4.14 056/242] ARM: dts: exynos: fix USB 3.0 VBUS control and over-current pins on Exynos5410 Date: Mon, 28 Dec 2020 13:47:41 +0100 Message-Id: <20201228124907.438782268@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201228124904.654293249@linuxfoundation.org> References: <20201228124904.654293249@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Krzysztof Kozlowski commit 3d992fd8f4e0f09c980726308d2f2725587b32d6 upstream. The VBUS control (PWREN) and over-current pins of USB 3.0 DWC3 controllers are on Exynos5410 regular GPIOs. This is different than for example on Exynos5422 where these are special ETC pins with proper reset values (pulls, functions). Therefore these pins should be configured to enable proper USB 3.0 peripheral and host modes. This also fixes over-current warning: [ 6.024658] usb usb4-port1: over-current condition [ 6.028271] usb usb3-port1: over-current condition Fixes: cb0896562228 ("ARM: dts: exynos: Add USB to Exynos5410") Signed-off-by: Krzysztof Kozlowski Cc: Link: https://lore.kernel.org/r/20201015182044.480562-2-krzk@kernel.org Tested-by: Gabriel Ribba Esteva Signed-off-by: Greg Kroah-Hartman --- arch/arm/boot/dts/exynos5410-pinctrl.dtsi | 28 ++++++++++++++++++++++++++++ arch/arm/boot/dts/exynos5410.dtsi | 4 ++++ 2 files changed, 32 insertions(+) --- a/arch/arm/boot/dts/exynos5410-pinctrl.dtsi +++ b/arch/arm/boot/dts/exynos5410-pinctrl.dtsi @@ -563,6 +563,34 @@ interrupt-controller; #interrupt-cells = <2>; }; + + usb3_1_oc: usb3-1-oc { + samsung,pins = "gpk2-4", "gpk2-5"; + samsung,pin-function = ; + samsung,pin-pud = ; + samsung,pin-drv = ; + }; + + usb3_1_vbusctrl: usb3-1-vbusctrl { + samsung,pins = "gpk2-6", "gpk2-7"; + samsung,pin-function = ; + samsung,pin-pud = ; + samsung,pin-drv = ; + }; + + usb3_0_oc: usb3-0-oc { + samsung,pins = "gpk3-0", "gpk3-1"; + samsung,pin-function = ; + samsung,pin-pud = ; + samsung,pin-drv = ; + }; + + usb3_0_vbusctrl: usb3-0-vbusctrl { + samsung,pins = "gpk3-2", "gpk3-3"; + samsung,pin-function = ; + samsung,pin-pud = ; + samsung,pin-drv = ; + }; }; &pinctrl_2 { --- a/arch/arm/boot/dts/exynos5410.dtsi +++ b/arch/arm/boot/dts/exynos5410.dtsi @@ -381,6 +381,8 @@ &usbdrd3_0 { clocks = <&clock CLK_USBD300>; clock-names = "usbdrd30"; + pinctrl-names = "default"; + pinctrl-0 = <&usb3_0_oc>, <&usb3_0_vbusctrl>; }; &usbdrd_phy0 { @@ -392,6 +394,8 @@ &usbdrd3_1 { clocks = <&clock CLK_USBD301>; clock-names = "usbdrd30"; + pinctrl-names = "default"; + pinctrl-0 = <&usb3_1_oc>, <&usb3_1_vbusctrl>; }; &usbdrd_dwc3_1 {