Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp9183917pxu; Mon, 28 Dec 2020 08:40:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJwjzhJDozMkLkkgP1PW8jDo4W5GwZB1NW93OyPwYRQ0+zZ625JlxyB5wOeQ41QI8U8saaq0 X-Received: by 2002:aa7:c492:: with SMTP id m18mr42397176edq.236.1609173638653; Mon, 28 Dec 2020 08:40:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609173638; cv=none; d=google.com; s=arc-20160816; b=rLmpmh/KaEX6oBeUVoqANQP3sUBjPtwVzb9lYZZcPNSAEYEEeRBuyoFnu8EZtur93a TcIHFWKV07LRsur0t9EmULCns4nJQnrAzl7DV1jd+mLZSOKSG8YB7cseelKEbDp70NXv QX9+EgPbrr4uHkTpyZ5tlVEv+ZNb6erpioO1gPfg1VCNnXzvrjo0feEr7C4cTcFdx9mC dZ4TUWW3yrrjrr28adlGgFWROsj5rsrrCKXBPuItTOfN9CctovVZusqHbhCVVcAK8AXy 7s4+7UdkuImWEsZFr/YgjM1sk5xX8jU4dPfbgq2pMLalhtiPC8OCBFNliUjGmoKtWVH3 F3/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=f/gTlQDl/FoQaerYzhVdNmycQ6bHEHM1Kxh7tH5lH7o=; b=uN8yaHp26snPCu5V8f08+zPLViHOJ32XdpYNJVfOqxGMaKBlF686WFtXSDeuOVqhQB dE+upxvFEU579BnGo5OXCOv0bYWsYv+bhJk+FkTT5BMnm27VlmY9ADVq0WHLVIR+f74O zhplxo+jC6FcCNndGNQ+/PqX/PHGm/9r3qlKXxNWoohVI4nvXb6wrTqMihAm+R8tu4pH +hoqcYWo4u/eK8NlIezINwpeCgSsXwTfysuqW10Db4M3J79LdGJ861sC3GgvRPq8kI8j yOGEaEej5eJv6C7MOMXA9Ul3afjBvikIfpgYdM0W/dZGbyTxRjVg1Q7UrFva3BsuoPcW KcbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2016061301 header.b=M34NbkJ5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t15si19652127edq.100.2020.12.28.08.40.16; Mon, 28 Dec 2020 08:40:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2016061301 header.b=M34NbkJ5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2438514AbgL1Qh7 (ORCPT + 99 others); Mon, 28 Dec 2020 11:37:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729574AbgL1NB3 (ORCPT ); Mon, 28 Dec 2020 08:01:29 -0500 Received: from ssl.serverraum.org (ssl.serverraum.org [IPv6:2a01:4f8:151:8464::1:2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 934EFC061795; Mon, 28 Dec 2020 05:00:48 -0800 (PST) Received: from mwalle01.fritz.box (unknown [IPv6:2a02:810c:c200:2e91:fa59:71ff:fe9b:b851]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 105B123E5D; Mon, 28 Dec 2020 14:00:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1609160445; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f/gTlQDl/FoQaerYzhVdNmycQ6bHEHM1Kxh7tH5lH7o=; b=M34NbkJ5wWnoIkIlPswBPoYonMRCaS6WeHLUsa423+CnZ8tvkJABM0MFy3r6a0m0fo9tBc yciItO302qkU6jm0x5YE0CIk62uu3C+xwieY5pYQblnjAsvTsY2LWMMvuswhbQ8nFd7DfC kVldc9O+4MFCDGAMLZL25JWJAEKqAVA= From: Michael Walle To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Claudiu Manoil , "David S . Miller" , Jakub Kicinski , Alex Marginean , Vladimir Oltean , Michael Walle , Andrew Lunn Subject: [PATCH RESEND net-next 3/4] enetc: drop MDIO_DATA() macro Date: Mon, 28 Dec 2020 14:00:33 +0100 Message-Id: <20201228130034.21577-4-michael@walle.cc> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201228130034.21577-1-michael@walle.cc> References: <20201228130034.21577-1-michael@walle.cc> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org value is u16, masking with 0xffff is a nop. Drop it. Signed-off-by: Michael Walle Reviewed-by: Andrew Lunn Reviewed-by: Vladimir Oltean Tested-by: Vladimir Oltean --- drivers/net/ethernet/freescale/enetc/enetc_mdio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/enetc/enetc_mdio.c b/drivers/net/ethernet/freescale/enetc/enetc_mdio.c index 665f7a0c71cb..591b16f01507 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc_mdio.c +++ b/drivers/net/ethernet/freescale/enetc/enetc_mdio.c @@ -41,7 +41,6 @@ static inline void enetc_mdio_wr(struct enetc_mdio_priv *mdio_priv, int off, #define MDIO_CTL_DEV_ADDR(x) ((x) & 0x1f) #define MDIO_CTL_PORT_ADDR(x) (((x) & 0x1f) << 5) #define MDIO_CTL_READ BIT(15) -#define MDIO_DATA(x) ((x) & 0xffff) static bool enetc_mdio_is_busy(struct enetc_mdio_priv *mdio_priv) { @@ -93,7 +92,7 @@ int enetc_mdio_write(struct mii_bus *bus, int phy_id, int regnum, u16 value) } /* write the value */ - enetc_mdio_wr(mdio_priv, ENETC_MDIO_DATA, MDIO_DATA(value)); + enetc_mdio_wr(mdio_priv, ENETC_MDIO_DATA, value); ret = enetc_mdio_wait_complete(mdio_priv); if (ret) -- 2.20.1