Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp9458456pxu; Mon, 28 Dec 2020 17:17:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJyT7XCxnSFWZr/5Ecvmxi1WmBPxlvregJWMp66ende33vN9Lm5ZjkdfqEqsQF+m7oYjHd46 X-Received: by 2002:a17:906:a011:: with SMTP id p17mr43059369ejy.30.1609204623506; Mon, 28 Dec 2020 17:17:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609204623; cv=none; d=google.com; s=arc-20160816; b=N7WWPOkSM3JR+tzxTSHCNSxNNXcBEU1ZF04gS/nOdBN6o0auzFxRncNJJwes34PdHR Woca3iJ/c/yBJ1e1s1uNq6bQcuFw+QnBA+g9cJfQnwXTEt1qG4bO02iOhO+HGwKkzxUa XbiX8J63shSet44jtgxBpWzACdp+b85JxwdbXc4mewJjZ0jxIEpkrXMQ8WwUAsU3qFZO aqRNKXkan/yIsT+iiaJ+T9tzrw0ZAgewV+ehEbBGxR5u6dxkATsp0qqmRDv0p7Fff9hj AeVEEd/HJZ7K/2KQOR6ndnzElnnujph+BnYy4CJxku+5R3dyywDBB359MMfsLniqzU4B EcLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=xo85X2Ouvk2qmQnbe1sme7C4PzCQCpFco37fNwH/Scw=; b=nQ9sDsCiCuhVKyx8Q97MXZMj4JHj62eok6ntoLLectIEzpI9aocIl4tSiY71rd9kHd +ltkqZucwnt8uOCBIKQB5bmgprOqh7StX926bN0jiHIf1Qz8+YguY1nZO/kLgwfMre8I BVxOzXpO8pZipf6+q9vtLFb70SpCUZjTSKG2BmpQo8aAeiQY+Y2GIVTfsor0AJ+wDsE1 BaFbMksGrtxGDeRx190sjJ1X97Kube9GMWJX92+cn+uKgfL4nyqCww/dJhjsX3K+8g2K Kc6RRxFt3ofdqiM8VywZWqn15G7vZJJnzd/pEU4EYagYgNXpdwwawM28VicoU0kIve3c T2eA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=Wni+jZvF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t6si18561429ejr.116.2020.12.28.17.16.41; Mon, 28 Dec 2020 17:17:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=Wni+jZvF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728018AbgL1RRm (ORCPT + 99 others); Mon, 28 Dec 2020 12:17:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727332AbgL1RRj (ORCPT ); Mon, 28 Dec 2020 12:17:39 -0500 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 786E7C0613D6 for ; Mon, 28 Dec 2020 09:16:58 -0800 (PST) Received: by mail-pf1-x42f.google.com with SMTP id t22so6599612pfl.3 for ; Mon, 28 Dec 2020 09:16:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xo85X2Ouvk2qmQnbe1sme7C4PzCQCpFco37fNwH/Scw=; b=Wni+jZvFm7AhNh6R/UDmCw93fnvISItY0FCW44F+YUw+sO/UbD4W259PR9P5/hzbyW vRr3cjrT2ez443blpaerWJoVACUjBl8KlDjB5FGByFUC+xDAml3CZdri6YbM5AGcpzlB uZ3aIwEmyebGp8PlA4u3jL9tupHhybz7bdolNVwZkNuckH/Us7Idxalz6DPXaq/zSf6d cSjo0lTIhflGk0gyeXDc6Qm4czM8wI59a8regxd/CNVHNm+3Dp8Mgn7iyAbHgw25+NqB JObnP5jMSLuN32Ws5qksu9JFA13k38Pm6GYL2wvtR4TVgR2TNXS/6hgpBGfVpnSVaTu4 xs9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xo85X2Ouvk2qmQnbe1sme7C4PzCQCpFco37fNwH/Scw=; b=e4EI09dKqQzg0qYEXX4qO4xLD4ar0az10ZUyHMSBP+hufDvxCiCgrgBDOEKBN09Mzv UlcpmZfda/qPUtuYADR5NDHdOMgUAqpAMqXY3Peo37Xmd4qbMqvhwqqMeM0ALkQVF1bs y2jHKf8sWflAyXeGCuAGF17l/gLPBC+fP99hAOECZDOgjnGZspMfURvkVTl2wFvJpq1l zmlVbDkgeInklglVSNV9P3u22fL4dgtUnptBfauBvcwCPsJ/U/6vpVvynuC0b8r802ko vg+CgtY5TmNElhKk4wJ5zWJkAQAtK86wh0kmAWSdjRbxsIYtgdE9S6redkELCdG8a8pK YpQg== X-Gm-Message-State: AOAM530GLx4tjGopcLN7JypGJpUjvLQ1D3CAT1Am8plhsvJ1RUjZTBrE cvqN+PPsrK+EC10wZ45+tuDHcQ== X-Received: by 2002:a62:ca:0:b029:19e:67a9:f0f2 with SMTP id 193-20020a6200ca0000b029019e67a9f0f2mr41177784pfa.60.1609175817956; Mon, 28 Dec 2020 09:16:57 -0800 (PST) Received: from google.com ([2620:15c:f:10:1ea0:b8ff:fe73:50f5]) by smtp.gmail.com with ESMTPSA id k25sm37172351pfi.10.2020.12.28.09.16.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Dec 2020 09:16:57 -0800 (PST) Date: Mon, 28 Dec 2020 09:16:50 -0800 From: Sean Christopherson To: Borislav Petkov Cc: Andy Lutomirski , Masami Hiramatsu , X86 ML , LKML Subject: Re: [PATCH v1 01/19] x86/insn: Rename insn_decode() to insn_decode_regs() Message-ID: References: <20201223174233.28638-1-bp@alien8.de> <20201223174233.28638-2-bp@alien8.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201223174233.28638-2-bp@alien8.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 23, 2020, Borislav Petkov wrote: > From: Borislav Petkov > > Rename insn_decode() to insn_decode_regs() to denote that it receives > regs as param and free the name for a more generic version of the > function. Can we add a preposition in there, e.g. insn_decode_from_regs() or insn_decode_with_regs()? For me, "decode_regs" means "decode the register operands of the instruction".