Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 28 Dec 2020 10:50:58 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Vincent Bernat <vincent@bernat.ch>,
        Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 5.10 098/717] net: evaluate
 net.ipvX.conf.all.ignore_routes_with_linkdown
Message-ID: <20201228105058.7c66e522@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20201228125025.671560851@linuxfoundation.org>
References: <20201228125020.963311703@linuxfoundation.org>
        <20201228125025.671560851@linuxfoundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 28 Dec 2020 13:41:36 +0100 Greg Kroah-Hartman wrote:
> From: Vincent Bernat <vincent@bernat.ch>
> 
> [ Upstream commit c0c5a60f0f1311bcf08bbe735122096d6326fb5b ]
> 
> Introduced in 0eeb075fad73, the "ignore_routes_with_linkdown" sysctl
> ignores a route whose interface is down. It is provided as a
> per-interface sysctl. However, while a "all" variant is exposed, it
> was a noop since it was never evaluated. We use the usual "or" logic
> for this kind of sysctls.

I'd recommend to drop 98 and 99, at least for now.

The kernel always behaved this way, and it remains to be seen if anyone
depended on that (mis) behavior.

This needs to hit a real release.