Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp9461793pxu; Mon, 28 Dec 2020 17:24:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJwFPsgxEI3IL4QuKjn9OduXu4/wx61m/posip0r3+x3+bIFRloN6eXNbvGVQPcqsnFR55vZ X-Received: by 2002:a17:906:518a:: with SMTP id y10mr44651962ejk.323.1609205045554; Mon, 28 Dec 2020 17:24:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609205045; cv=none; d=google.com; s=arc-20160816; b=Qpivefe+A8DsSP3Ybje6gMqB3rD71tbI0o72FJJ2tq0G3PL946ceeD0AbnrLByFDJ6 6TjyBux8ikQ4ckOFzqI9bhyNq0jBTQWWyuHiE/WUssuGlWI39UVoMCSB21vKA73KacvU DAPIF01NG5FCvtjz0qtu/FvS6NqtN6WFR7LKjgtS17zoK/rlfhO8VNVD2+ppgH4de19+ KLZQqespzpDg6G6Iq42Of8PWyXdN7wwCR50bFcJ0WXSqdkWfSkTGVYjnF6RyGyyEN3pK GBAd5L3hRlVnYngQjAx2d9HOzetfeajFURUyCeK9eJ6ehs3arcsXRQ6/5Wl+hE7YV4zQ UclA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=NWnEu5HaAGiZiFcDZvuHZGseyVq9ff5u4/mPVtDJ6fM=; b=pDM+ditPMAvu/58hAekXBkHhNOKDxEP/77YFCa/OVWMUoSOc0JWvaoLnEu4/sW46HP 40qEDSDQ6IEktbKhtiUBJeteHOd4CX0CcjFhocXyErmdEnDBxzyhNeI3Kch/6hrissoa yVW+ltPhnRX8G2sFXxokK0Z0E6kxsUVUzxBkdz8dlKL4VxsaHVSVoYBC1KYTC9+vbv6G FKDs92/xalCyXpe9HFSNCdWNrS8ZWh2L2oWqCdEKUOUciDH4VI7cBxwpIbdj6mciww9d WrUrcqZsOOUU0c8ReVaJNrC71nNprAJAdxInZJ/OC3XwI9wb+p6y3wdqylMpzaYsj0rl oARA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CAC3xZ6S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y7si6925581edt.257.2020.12.28.17.23.43; Mon, 28 Dec 2020 17:24:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CAC3xZ6S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728095AbgL1SzG (ORCPT + 99 others); Mon, 28 Dec 2020 13:55:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:38836 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726420AbgL1SzF (ORCPT ); Mon, 28 Dec 2020 13:55:05 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id EC9F6221F8; Mon, 28 Dec 2020 18:54:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609181665; bh=NWnEu5HaAGiZiFcDZvuHZGseyVq9ff5u4/mPVtDJ6fM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CAC3xZ6SWM5I7K7ey7IlppP2BHU56kZMHBGKAqFeCphiW5FX0Rep3t1VD216BhO99 Q1jemfpEJz/7U5lTv583EQTHRmA9c5X1qtNPXDtQXDC/5IYZS/SSaZ9xBnZLjLWXur tVo6FBppZGHhFiJcEnUOZPGXiC6vAeyJL2indVUi1S3SL2ttaV4hadoIjQz3iHxS2g L2MmX3eVMyzVPI4BtBVzkYu+xHbQmLETwyxyVnelAs3KTt5og9du0BYvjcTV9PaVpt 7j1IOZlrGRbzAq5NRgRi69acSG4Uf4FL2TcR1+XyCJuUDYm3VfHSSK+9HHYZhRET+y F2hhdwBumCaEQ== Date: Mon, 28 Dec 2020 10:54:23 -0800 From: Jakub Kicinski To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, =?UTF-8?B?Qmo=?= =?UTF-8?B?w7ZybiBUw7ZwZWw=?= , Sasha Levin Subject: Re: [PATCH 5.10 462/717] ice, xsk: clear the status bits for the next_to_use descriptor Message-ID: <20201228105423.46e77460@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20201228125043.105740628@linuxfoundation.org> References: <20201228125020.963311703@linuxfoundation.org> <20201228125043.105740628@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 28 Dec 2020 13:47:40 +0100 Greg Kroah-Hartman wrote: > From: Bj=C3=B6rn T=C3=B6pel >=20 > [ Upstream commit 8d14768a7972b92c73259f0c9c45b969d85e3a60 ] >=20 > On the Rx side, the next_to_use index points to the next item in the > HW ring to be refilled/allocated, and next_to_clean points to the next > item to potentially be processed. >=20 > When the HW Rx ring is fully refilled, i.e. no packets has been > processed, the next_to_use will be next_to_clean - 1. When the ring is > fully processed next_to_clean will be equal to next_to_use. The latter > case is where a bug is triggered. >=20 > If the next_to_use bits are not cleared, and the "fully processed" > state is entered, a stale descriptor can be processed. >=20 > The skb-path correctly clear the status bit for the next_to_use > descriptor, but the AF_XDP zero-copy path did not do that. >=20 > This change adds the status bits clearing of the next_to_use > descriptor. >=20 > Fixes: 2d4238f55697 ("ice: Add support for AF_XDP") > Signed-off-by: Bj=C3=B6rn T=C3=B6pel > Signed-off-by: Jakub Kicinski > Signed-off-by: Sasha Levin Oh wow, so much for Sasha waiting longer for code to get tested before auto-pulling things into stable :/ I have this change and other changes here queued, but haven't sent the submission yet. How long is the auto-backporting delay in terms of calendar days?