Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030251AbWIFXuc (ORCPT ); Wed, 6 Sep 2006 19:50:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030255AbWIFXuc (ORCPT ); Wed, 6 Sep 2006 19:50:32 -0400 Received: from mailout.stusta.mhn.de ([141.84.69.5]:59908 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S1030251AbWIFXub (ORCPT ); Wed, 6 Sep 2006 19:50:31 -0400 Date: Thu, 7 Sep 2006 01:50:29 +0200 From: Adrian Bunk To: Roman Zippel Cc: Andi Kleen , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [2.6 patch] re-add -ffreestanding Message-ID: <20060906235029.GC25473@stusta.de> References: <20060830175727.GI18276@stusta.de> <200608302013.58122.ak@suse.de> <20060830183905.GB31594@flint.arm.linux.org.uk> <20060906223748.GC12157@stusta.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1373 Lines: 41 On Thu, Sep 07, 2006 at 01:38:01AM +0200, Roman Zippel wrote: > Hi, Hi Roman, > On Thu, 7 Sep 2006, Adrian Bunk wrote: > > > We are talking about reverting the patch that removed -ffreestanding, > > and that broke at least two architectures although it wrongly claimed > > it would have been a safe patch. > > Your patch is nevertheless the wrong fix for one of these archs. it's correct, since with -ffreestanding gcc no longer has the right to assume it had a full libc available. Yes, -ffreestanding disables gcc builtins, but the correct fix for this issue is not to remove -ffreestanding, but to check where we want to use gcc builtins and enable them explicitely. This takes more time than the quick'n'dirty patch that removed -ffreestanding, but it does it right (and we might perhaps get rid of things like include/asm-i386/string.h). > bye, Roman cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/