Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 28 Dec 2020 13:33:09 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Richard Cochran <richardcochran@gmail.com>,
        Grygorii Strashko <grygorii.strashko@ti.com>
Cc:     "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Lokesh Vutla <lokeshvutla@ti.com>
Subject: Re: [PATCH net] net: ethernet: ti: cpts: fix ethtool output when no
 ptp_clock registered
Message-ID: <20201228133309.7d0c1047@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20201224212136.GB1229@hoboy.vegasvil.org>
References: <20201224162405.28032-1-grygorii.strashko@ti.com>
        <20201224212136.GB1229@hoboy.vegasvil.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 24 Dec 2020 13:21:36 -0800 Richard Cochran wrote:
> On Thu, Dec 24, 2020 at 06:24:05PM +0200, Grygorii Strashko wrote:
> > The CPTS driver registers PTP PHC clock when first netif is going up and
> > unregister it when all netif are down. Now ethtool will show:
> >  - PTP PHC clock index 0 after boot until first netif is up;
> >  - the last assigned PTP PHC clock index even if PTP PHC clock is not
> > registered any more after all netifs are down.
> > 
> > This patch ensures that -1 is returned by ethtool when PTP PHC clock is not
> > registered any more.
> > 
> > Fixes: 8a2c9a5ab4b9 ("net: ethernet: ti: cpts: rework initialization/deinitialization")
> > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>  
> 
> Acked-by: Richard Cochran <richardcochran@gmail.com>

Applied, thank you!