Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp9465125pxu; Mon, 28 Dec 2020 17:31:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJyKSQqikCdS/g81GSACFAvTwr+LYACozlH7YixdzahXJJDpeW61Df2FClOzLoEs0r6WdrJd X-Received: by 2002:a05:6402:1c90:: with SMTP id cy16mr44884277edb.73.1609205491224; Mon, 28 Dec 2020 17:31:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609205491; cv=none; d=google.com; s=arc-20160816; b=imZLKZhpQ3GKX6DdNW0Zvx86MF3nWoeh5OTUDXB/Isx2oN1f/8Xcxe/W55HzuQPjuf w70x0k8f7Z3PdYZl6OI8Jl0fdkwBX9SMm2myJvTIgMCGTo9fJkuf4yBp55roH7diXnN5 xmvv+w21+/wf8qaXnrgrqjgnd0dxDZjkHqXpzKomLDna8iO04GJdHZzuzm3QjEUJUjRd v+171sBbphL+fqkPeptOHmhDKnRwVIdCTodNGvWqv2MeWn+oipOSJjV0LJg7dnOz2tYA nTd3VY5iddZmDTbFtn2xm6pmGlLLkmFF98aM17DZiKmneRpBeiy67bVmjHaL0BE9yMGG oLYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=AeM6r9Ik6bCLGOPcMTUziMSurI0N3sHJOJg+K77P2Dc=; b=PEqluXHBkbTVVpDdUof5rgsqTWCkOC7vQ/PhScvGqLnkk1bzbAczgcSNBajQhb1kyd 1YQl01feBnLFQgqShMHSEfgrwd0xS7eHkPngEaqi+FUMmJhP42ChLt3vP3tTyS74wjoa gUuZc/HqXD3A39j+4ZahNccC+jQK8+0f3wtGLjASFVaJOvBEVgCJkMHz2h/7y+igVGMe Ic+tysF6/RWBRWHsB2Xg0h6a6SoIwPxGjIS3jX6yrUjZqtJnnhcT7YcWNFxRCrS20qSW JbfLWy9R2S4dGHO2aJlcwtbogdx7nJm8JmmdlHfcfdT5p5jVhiPxb58hO/ObeDl8gbit D1sQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cb20si19495500ejb.329.2020.12.28.17.31.09; Mon, 28 Dec 2020 17:31:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730671AbgL1XAo (ORCPT + 99 others); Mon, 28 Dec 2020 18:00:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730482AbgL1XAh (ORCPT ); Mon, 28 Dec 2020 18:00:37 -0500 Received: from mail.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72772C0613D6; Mon, 28 Dec 2020 14:54:44 -0800 (PST) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) by mail.monkeyblade.net (Postfix) with ESMTPSA id 93CCF4CE93100; Mon, 28 Dec 2020 14:54:01 -0800 (PST) Date: Mon, 28 Dec 2020 14:54:01 -0800 (PST) Message-Id: <20201228.145401.2067471886598959966.davem@davemloft.net> To: rdunlap@infradead.org Cc: linux-kernel@vger.kernel.org, syzbot+97c5bd9cc81eca63d36e@syzkaller.appspotmail.com, nogahf@mellanox.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, netdev@vger.kernel.org, kuba@kernel.org Subject: Re: [PATCH -net] net: sched: prevent invalid Scell_log shift count From: David Miller In-Reply-To: <20201225062344.32566-1-rdunlap@infradead.org> References: <20201225062344.32566-1-rdunlap@infradead.org> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (mail.monkeyblade.net [0.0.0.0]); Mon, 28 Dec 2020 14:54:01 -0800 (PST) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Randy Dunlap Date: Thu, 24 Dec 2020 22:23:44 -0800 > Check Scell_log shift size in red_check_params() and modify all callers > of red_check_params() to pass Scell_log. > > This prevents a shift out-of-bounds as detected by UBSAN: > UBSAN: shift-out-of-bounds in ./include/net/red.h:252:22 > shift exponent 72 is too large for 32-bit type 'int' > > Fixes: 8afa10cbe281 ("net_sched: red: Avoid illegal values") > Signed-off-by: Randy Dunlap > Reported-by: syzbot+97c5bd9cc81eca63d36e@syzkaller.appspotmail.com Applied and queued up for -stable, thanks.