Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 29 Dec 2020 00:02:24 +0100
From:   Jiri Olsa <jolsa@redhat.com>
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
        lkml <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Ingo Molnar <mingo@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Michael Petlan <mpetlan@redhat.com>,
        Song Liu <songliubraving@fb.com>,
        Stephane Eranian <eranian@google.com>,
        Alexei Budankov <abudankov@huawei.com>,
        Andi Kleen <ak@linux.intel.com>,
        Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH 15/15] perf record: Add --buildid-mmap option to enable
 mmap's build id
Message-ID: <20201228230224.GE450923@krava>
References: <20201214105457.543111-1-jolsa@kernel.org>
 <20201214105457.543111-16-jolsa@kernel.org>
 <20201228134437.GC521329@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201228134437.GC521329@kernel.org>
Precedence: bulk

On Mon, Dec 28, 2020 at 10:44:37AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Dec 14, 2020 at 11:54:57AM +0100, Jiri Olsa escreveu:
> > Adding --buildid-mmap option to enable build id in mmap2 events.
> > It will only work if there's kernel support for that and it disables
> > build id cache (implies --no-buildid).
> > 
> > It's also possible to enable it permanently via config option
> > in ~.perfconfig file:
> > 
> >   [record]
> >   build-id=mmap
> > 
> > Also added build_id bit in the verbose output for perf_event_attr:
> > 
> >   # perf record --buildid-mmap -vv
> >   ...
> >   perf_event_attr:
> >     type                             1
> >     size                             120
> >     ...
> >     build_id                         1
> > 
> > Adding also missing text_poke bit.
> 
> I'm moving this to just before the:
> 
>   perf tools: Add support to display build id when available in PERF_RECORD_MMAP2 events
> 
> So that I can actually print the synthesized/obtained from the kernel
> build-ids, i.e. this:
> 
>   perf report -D | grep MMAP2 | head -4
> 
> Will work at that point.

ok, thanks

jirka