Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp9467977pxu; Mon, 28 Dec 2020 17:37:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJyTCcYoJ8lsZ3T5xujyQB7crKiAN9SXAOOaJ77n4BGpqHc7oYJH8DLAnxTmnRWvCUknmeK6 X-Received: by 2002:aa7:d494:: with SMTP id b20mr45723409edr.330.1609205854510; Mon, 28 Dec 2020 17:37:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609205854; cv=none; d=google.com; s=arc-20160816; b=d71l3DkVbjXrr2BOXK848V7kwdS85OMXALFB7i+JpHOmjI79SwEKRYtsZJISTfDiwC 4RHAs2zGm8/vVWKHOw2We4jRWnxVojvo5yDg41xL7kgIX40CmxfSC7n+OmI5yqAznclM ApYIK8olPW4rWdB6UyTwVQEV+su3/0cExby4GjFY5mUlaTukeBi8pbWkmPdX0GZ3AvNx QmzMpr65vpXHxwNn6hRTDsQ16L6ERB6PGI4777sdDxENz3wAKwffy5zwuTIMgGjYhjeG 5wJxNg+0eVKnFOuOq/8+O+nnoxcKR4z/OCmvRO23REiEzbeCdHPeIDxGIHo9+9emzSHk Ia3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=z13+Md1+4UrP/kmsDzK9ldSeOHvgAH3SZtZS39betwc=; b=DS/ZBmDfTxvoK2fTlJJwtZMVb4GSZ0OKA0oB01g2DMCmMnKNOyQXmCBtew6f5u/cUT Dxfz1Vu8x0uve1+4Sb6pi6IEV6DcjU2QFr6EFL/XivdCm51bFdZPtdX7XG8LkqXuAZKJ Ds9gQxEDngBebWWYrpFeRuvWcbgDABwn2Clvu8VhNQ0jjKCwAMdpJaaLtXC8Omqz4D4c 5gBV7wBa0x9jEIsBz1W+bGPB+h+AX7W1/d0c5reYEopv6bO7eyzZ+yYc+KWpmAZO586U nXYCykUbQB8CQsPSssrOWHTAFhVJy3sjbC1oOvay5X2FeGcIHyrcRBfadTTSSLP1y8cR hD9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Y23hlb09; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bg8si12533982ejb.144.2020.12.28.17.37.12; Mon, 28 Dec 2020 17:37:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Y23hlb09; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731151AbgL1W4B (ORCPT + 99 others); Mon, 28 Dec 2020 17:56:01 -0500 Received: from mail.kernel.org ([198.145.29.99]:47772 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729431AbgL1Ujr (ORCPT ); Mon, 28 Dec 2020 15:39:47 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id BC7C5222B3; Mon, 28 Dec 2020 20:39:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609187947; bh=VTWjReRS4Z3OBvORpv7OORcjw+MCvDX/NCFz7CoDXW0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Y23hlb09w0/oRIEHJpjilrTMMORnC6qmkyLC4jxkcp6YcWlpxOUcGVUOfwaKeiBl1 wUCLoLHUkWmbutS2FWw4qGTiLqMeOmyQBIQeXsL/8yAZUDdpCgYACLTW2hP1kHmds8 PZW/BaxOTU4C3glzebGFNSLrC/+mdG8urrFXmMX5QijMPTtp8ipFDf0pXw5JGh/6Az cw2cnfnEVpI7vyYDn5FLTOc67Vry3Np6zEjbWg/C/I+RoK0YH4elaiZiv7niS54D8s Lcvog+wj+cE3FpGejE1ZCExsqoA/hYzN8rPYsKD/6NbzjKfT1ZV1A/s0etGcfALlBZ ycmM9nBREEkgg== Date: Mon, 28 Dec 2020 12:39:06 -0800 From: Jakub Kicinski To: Sieng Piaw Liew Cc: Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 0/6] bcm63xx_enet: major makeover of driver Message-ID: <20201228123906.69b929e5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20201224142421.32350-1-liew.s.piaw@gmail.com> References: <20201224142421.32350-1-liew.s.piaw@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 24 Dec 2020 22:24:15 +0800 Sieng Piaw Liew wrote: > This patch series aim to improve the bcm63xx_enet driver by integrating the > latest networking features, i.e. batched rx processing, BQL, build_skb, etc. > > The newer enetsw SoCs are found to be able to do unaligned rx DMA by adding > NET_IP_ALIGN padding which, combined with these patches, improved packet > processing performance by ~50% on BCM6328. > > Older non-enetsw SoCs still benefit mainly from rx batching. Performance > improvement of ~30% is observed on BCM6333. > > The BCM63xx SoCs are designed for routers. As such, having BQL is beneficial > as well as trivial to add. Hopefully we can get some reviews now, but for inclusion in the tree you'll need to repost once net-next opens (should happen in the next few days): http://vger.kernel.org/~davem/net-next.html