Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <CA+icZUUQRKuZzN0ZbaG6vprRWcKPKYVYTryiMFac7q_PRcBvgA@mail.gmail.com>
 <CA+icZUWHiCu9=+80Z8OV+Q3r-TJ4Vm0t62P_Qgck5bRzjrtaWg@mail.gmail.com> <CAHk-=wh3AsdUVZ8GKNCdUmY0_nGmoiOVTwy7rR5QM7K31QiSqw@mail.gmail.com>
In-Reply-To: <CAHk-=wh3AsdUVZ8GKNCdUmY0_nGmoiOVTwy7rR5QM7K31QiSqw@mail.gmail.com>
Reply-To: sedat.dilek@gmail.com
From:   Sedat Dilek <sedat.dilek@gmail.com>
Date:   Mon, 28 Dec 2020 21:05:23 +0100
Message-ID: <CA+icZUVGKq=_9kJGo7Xgn_MV-ErsEWyY1pXU-aEL7BdWdQDjng@mail.gmail.com>
Subject: Re: Linux 5.11-rc1
To:     Linus Torvalds <torvalds@linux-foundation.org>
Cc:     Masahiro Yamada <masahiroy@kernel.org>,
        Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Dec 28, 2020 at 8:40 PM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> On Mon, Dec 28, 2020 at 12:04 AM Sedat Dilek <sedat.dilek@gmail.com> wrote:
> >
> > > $ dpkg -L kmod | grep bin | grep depmod
> > > /sbin/depmod
> > >
> > > $ which depmod
> > > [ empty ]
> > >
> > > $ echo $PATH
> > > /opt/proxychains-ng/bin:/home/dileks/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
>
> Ok, I think this is a broken setup that has a separate /sbin but does
> not have it in the PATH.
>
> As you noticed, you can fix it with
>
>    DEPMOD=/sbin/depmod
>
> or you could just make /sbin part of your PATH.
>
> It looks like on your distro, /sbin is restricted to just the
> super-user PATH, which is odd, but I guess there's at least _some_
> logic to it.
>
> I guess we could have some compatibility thing in scripts/depmod.sh,
> something like
>
>   diff --git a/scripts/depmod.sh b/scripts/depmod.sh
>   index e083bcae343f..a93261207453 100755
>   --- a/scripts/depmod.sh
>   +++ b/scripts/depmod.sh
>   @@ -15,6 +15,8 @@ if ! test -r System.map ; then
>         exit 0
>    fi
>
>   +# legacy behavior: "depmod" in /sbin
>   +PATH="$PATH:/sbin"
>    if [ -z $(command -v $DEPMOD) ]; then
>         echo "Warning: 'make modules_install' requires $DEPMOD. Please
> install it." >&2
>         echo "This is probably in the kmod package." >&2
>
> or similar. Does that work for you?
>

Looks like it works.

I see:

  sh ./scripts/depmod.sh depmod 5.11.0-rc1-2-amd64-clang-ias

But no more a depmod warning.

Will you send a patch or apply this directly?

- Sedat -