Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <4aeb47e4aa643181e462328104ef63c66eaf587b.camel@perches.com>
Subject: Re: [PATCH 8455/8455] staging: rtl8188eu: core: fixed a comment
 format issue.
From:   Joe Perches <joe@perches.com>
To:     Greg KH <gregkh@linuxfoundation.org>,
        Daniel West <daniel.west.dev@gmail.com>
Cc:     Larry.Finger@lwfinger.net, devel@driverdev.osuosl.org,
        insafonov@gmail.com, gustavoars@kernel.org,
        andrealmeidap1996@gmail.com, linux-kernel@vger.kernel.org,
        yepeilin.cs@gmail.com
Date:   Mon, 28 Dec 2020 11:47:27 -0800
In-Reply-To: <X+nnAwy/a7mZlmeL@kroah.com>
References: <20201219224312.380126-1-daniel.west.dev@gmail.com>
         <X+nnAwy/a7mZlmeL@kroah.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.38.1-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Mon, 2020-12-28 at 15:09 +0100, Greg KH wrote:
> On Sat, Dec 19, 2020 at 02:43:12PM -0800, Daniel West wrote:
> > Fixed a checkpatch warning:
> > 
> > WARNING: Block comments use * on subsequent lines
> > ?#4595: FILE: drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4595:
> > +/****************************************************************************
> > +
> > 
> > The code is full of comments like this. Should the coding style
> > be inforced here, even when there is a logic to the way the code
> > was broken up?
[]
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
[]
> > @@ -4591,11 +4591,10 @@ void mlmeext_sta_del_event_callback(struct adapter *padapter)
> > ?	}
> > ?}
> > ?
> > 
> > -/****************************************************************************
> > -
> > -Following are the functions for the timer handlers
> > -
> > -*****************************************************************************/
> > +/*
> > + *
> > + *Following are the functions for the timer handlers
> > + */
> 
> Does that look correct?  Make it all one line please.

Just:

/* timer handler functions */

would be simpler.

And the code is mostly a horror to read.