Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp9608115pxu; Mon, 28 Dec 2020 23:18:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJzd+W0zYDip54+HJ41AQTJbD4YOFQbKMXDdcW8r5Wx+lvGZ70+JSzgQUUJufBHev1pS71bd X-Received: by 2002:a50:cd9c:: with SMTP id p28mr44077087edi.83.1609226315802; Mon, 28 Dec 2020 23:18:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609226315; cv=none; d=google.com; s=arc-20160816; b=OyBLVPSCHWVVVKasd1+ymrXPRJxqPo5dEcjlaKuVo2ZmMjs0iCBD3PjepPfP7Wyne7 J72FOceTSswYlPAXhZBzz+XgEGoYr//BMTcfJpfK10+pn6NXnMN6IZfFuZkp9K9EtLqJ 2LmXBPM/PsZ6JLLNPzqneK+wfUsye2+8FP6C3+QpZ3w7zzGkhTYwgqXw6frWaB6BA1ro f5GYTNFUbv66i3XebcLoYMqo9cnqjDZhayRXOf20Vt4Tj3BCLV0E42NyXFhZmtn187WG aZFSKo5v1c+P4l607Ycvzd1qFcJOOMafBHgg1XQnaqk38HcEU4VhjltmX09GXWzHaLbt 9rDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=qqHVeipAAn5HMfg4BGEG2R4b8Vu+PvqL+WIcqgINTlo=; b=EhLyy1jaOiZlmlTvI3AN+sFQhkHGQsWvoeJ6I14pb8Y8CkrBXGVZq/3ZhzJqVHu81H klN8aNp8MhnIu2sgWs9XWN+Q+/HCbA1+IBdPUW7/jgaGKypv03ayN6HMHFpdPk0/BCrN WvBk3kRe6Yxb+e+gttmT2u7/16z1BELkq8u4TxOmT+jLyhi/T2Cov2AdaNlWs2asOaT3 aJ1SPAx2Mwj7MvdMLzYWIQ7iNwUkbImP3ArV3nVYBNZsbImhEsjuqvTKkFfvL9I9Sa4q 69UMIiEIbPqZpC0dr1nHQXCf73pYuU2FTB9ul0ZPq4RC8kbM8UroHJz5mJRFEbTHd7qV cUlg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=fNXxRobb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h8si19878219ejf.491.2020.12.28.23.18.12; Mon, 28 Dec 2020 23:18:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=fNXxRobb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726227AbgL2HQM (ORCPT + 99 others); Tue, 29 Dec 2020 02:16:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726014AbgL2HQK (ORCPT ); Tue, 29 Dec 2020 02:16:10 -0500 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE44FC0613D6 for ; Mon, 28 Dec 2020 23:15:29 -0800 (PST) Received: by mail-pl1-x635.google.com with SMTP id r4so6795664pls.11 for ; Mon, 28 Dec 2020 23:15:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=qqHVeipAAn5HMfg4BGEG2R4b8Vu+PvqL+WIcqgINTlo=; b=fNXxRobba/lDNvHQfOn9zTFnWrjkap5kX646v9VVly9oR+iwfkdTNs9jlWfmp625VD Ecs3VY0t2CW1/XIp+y+u9wJrc0ZwLUJz7DBMd+GWXj/6cj3Hs+WSDaLjJ40TKZINyXKj mqWQPjWNuXK7lI0A2qtJuApAP3REoqdWWeZ/f2SVT4PI0hhvx8o5SwZlDMOzPCKJABwb yr8lgWJ2+w2piJkmBpEPN6W8DCBz6qGXm6W176wB8Cgo/Zi+jxLVhmUy/lwan05jaJ4W UneiJrHiGuhkGenYqQhcOeEZFQPjXWkALqPT3C9Owdmt4oV2lkLEUbE/UpudWPkA/YdK RGRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=qqHVeipAAn5HMfg4BGEG2R4b8Vu+PvqL+WIcqgINTlo=; b=MIq778mfrzhTyEvIxh5O2iSe1V4M3SjELbV7G8UHPR5ULpJKajjvddLHQzd2NflYCx u2mK0jWraKQ8jxEeqbMzEjPShtcED0g23uEqBKRmgz49o1qzDGI3KVY0FO7Ti7Wi+D8z THa5aeZiaZ8GYx67+eVOUJv2uketuQv+WpmSAZ+Can21wNIaC6Szpqo+OelR9Rt56D0D PA8MlY9FVckodg/ZCTzUrHUSWObFx9kKCi3YQ8Ixa/EO8L9vw64N7IvGgyg8LUFpn+fX 9GFGSn2jmD/ROKt2vAUKcBwgEUhjxUZNxkh9oFlaXtVJPXZpfzI4kJU/CyIuc8yO7TxH 3Gsw== X-Gm-Message-State: AOAM533kw/WHpMQvSoB5Ezv9k4yNdjKlFLlC0GLVZOkSkOKcTHaX8uuq O4vptgfxSbHdXRRt3JjOcHE= X-Received: by 2002:a17:902:d202:b029:dc:3b92:f4e0 with SMTP id t2-20020a170902d202b02900dc3b92f4e0mr38630967ply.69.1609226129434; Mon, 28 Dec 2020 23:15:29 -0800 (PST) Received: from localhost.localdomain ([122.10.161.207]) by smtp.gmail.com with ESMTPSA id p9sm1929261pjb.3.2020.12.28.23.15.27 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Dec 2020 23:15:28 -0800 (PST) From: Yejune Deng To: tglx@linutronix.de, maz@kernel.org Cc: linux-kernel@vger.kernel.org, yejune.deng@gmail.com Subject: [PATCH] irqchip/gic: add WARN_ON() to facilitate backtracking Date: Tue, 29 Dec 2020 15:15:14 +0800 Message-Id: <1609226114-32933-1-git-send-email-yejune.deng@gmail.com> X-Mailer: git-send-email 1.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is two function gic_of_init() and gic_of_init_child() called gic_of_setup(),so add WARN_ON() to facilitate backtracking. Signed-off-by: Yejune Deng --- drivers/irqchip/irq-gic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c index b1d9c22..7c11705 100644 --- a/drivers/irqchip/irq-gic.c +++ b/drivers/irqchip/irq-gic.c @@ -1380,7 +1380,7 @@ static bool gic_check_eoimode(struct device_node *node, void __iomem **base) static int gic_of_setup(struct gic_chip_data *gic, struct device_node *node) { - if (!gic || !node) + if (WARN_ON(!gic || !node)) return -EINVAL; gic->raw_dist_base = of_iomap(node, 0); -- 1.9.1