Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] mm/page_reporting: use list_entry_is_head() in
 page_reporting_cycle()
To:     sh <sh_def@163.com>, akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <20201222182735.GA1257912@ubuntu-A520I-AC>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat GmbH
Message-ID: <3897f709-3bc8-2204-5e85-09790779e292@redhat.com>
Date:   Tue, 29 Dec 2020 10:16:25 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
MIME-Version: 1.0
In-Reply-To: <20201222182735.GA1257912@ubuntu-A520I-AC>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 22.12.20 19:27, sh wrote:
> replace '&next->lru != list' with list_entry_is_head().
> No functional change.
> 
> Signed-off-by: sh <sh_def@163.com>
> ---
>  mm/page_reporting.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/page_reporting.c b/mm/page_reporting.c
> index cd8e13d41df4..c50d93ffa252 100644
> --- a/mm/page_reporting.c
> +++ b/mm/page_reporting.c
> @@ -211,7 +211,7 @@ page_reporting_cycle(struct page_reporting_dev_info *prdev, struct zone *zone,
>  	}
>  
>  	/* Rotate any leftover pages to the head of the freelist */
> -	if (&next->lru != list && !list_is_first(&next->lru, list))
> +	if (!list_entry_is_head(next, list, lru) && !list_is_first(&next->lru, list))
>  		list_rotate_to_front(&next->lru, list);
>  
>  	spin_unlock_irq(&zone->lock);
> 

LGTM

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb