Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/1] mm: mmap: Remove unnecessary local variable
To:     Adrian Huang <adrianhuang0701@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Adrian Huang <ahuang12@lenovo.com>
References: <20201222103249.30683-1-adrianhuang0701@gmail.com>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat GmbH
Message-ID: <da7962ac-e5dc-9113-6444-c03e7850f83b@redhat.com>
Date:   Tue, 29 Dec 2020 10:17:46 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
MIME-Version: 1.0
In-Reply-To: <20201222103249.30683-1-adrianhuang0701@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 22.12.20 11:32, Adrian Huang wrote:
> From: Adrian Huang <ahuang12@lenovo.com>
> 
> The local variable 'retval' is assigned just for once in __do_sys_brk(),
> and the function returns the value of the local variable right after
> the assignment. Remove unnecessary assignment and local variable
> declaration.
> 
> Signed-off-by: Adrian Huang <ahuang12@lenovo.com>
> ---
>  mm/mmap.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/mm/mmap.c b/mm/mmap.c
> index dc7206032387..482c0c0bbe06 100644
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -189,7 +189,6 @@ static int do_brk_flags(unsigned long addr, unsigned long request, unsigned long
>  		struct list_head *uf);
>  SYSCALL_DEFINE1(brk, unsigned long, brk)
>  {
> -	unsigned long retval;
>  	unsigned long newbrk, oldbrk, origbrk;
>  	struct mm_struct *mm = current->mm;
>  	struct vm_area_struct *next;
> @@ -281,9 +280,8 @@ SYSCALL_DEFINE1(brk, unsigned long, brk)
>  	return brk;
>  
>  out:
> -	retval = origbrk;
>  	mmap_write_unlock(mm);
> -	return retval;
> +	return origbrk;
>  }

Reviewed-by: David Hildenbrand <david@redhat.com>


-- 
Thanks,

David / dhildenb