Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 29 Dec 2020 13:06:29 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Tim Harvey <tharvey@gateworks.com>
Cc:     "Rafael J . Wysocki" <rafael@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org,
        Laxminath Kasam <lkasam@codeaurora.org>,
        Tony Lindgren <tony@atomide.com>,
        Lee Jones <lee.jones@linaro.org>,
        Robert Jones <rjones@gateworks.com>
Subject: Re: [PATCH] regmap: irq: do not allow setting irq bits during ack
Message-ID: <20201229130629.GD4786@sirena.org.uk>
References: <1609191951-15590-1-git-send-email-tharvey@gateworks.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ZJcv+A0YCCLh2VIg"
Content-Disposition: inline
In-Reply-To: <1609191951-15590-1-git-send-email-tharvey@gateworks.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--ZJcv+A0YCCLh2VIg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Dec 28, 2020 at 01:45:51PM -0800, Tim Harvey wrote:

> Some interrupt controllers may not de-assert their interrupt if
> bits are set when acknowledging the bits that caused the interrupt.

> Take care to not apply the mask to the status until we are done
> acknowledging the interrupt and take care to mask the bits according
> for the ack_invert state.

I can't understand what this commit message is trying to say, sorry.
Which bits are you talking about when you say "if bits are set"?  Isn't
acknowleding the interrupt clearing the bits asserting the interrupt?  I
can't tell what the problem you're trying to fix is.

--ZJcv+A0YCCLh2VIg
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl/rKdUACgkQJNaLcl1U
h9B8HQgAhuWZe3NhnIBuOga3GlhY+ondsTBRTDwS7Sz/mC8Vs7jQ7OScNZAKNfra
L/dRgiQZb1oSikCid09gBzqvv4qd3OFwUNYrlW/GmxBmk1mEMtKqJ6ZmDaAWN5mY
DM/xoEKOkS8QvgaGrHTmvi7LCx1NOp7DqPMXHDMIlIy3xEsDhNdJOmL3lvIe0vnR
9XVxgNF4o4mV1fMk+Lg0/BvopSrT99m4ebfxcf53V3NbgjU0zTApZ/VPH2mtlA+p
RowjkFmAzKrfqPtWHdSVBakvfuXKb9RGzJZ5VxNiRIKJWxNozeG80Mg7NFMHFLIN
lYKZy7gpVbUBIwsFRVaeuW/NgTWpeQ==
=0Mb5
-----END PGP SIGNATURE-----

--ZJcv+A0YCCLh2VIg--