Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964883AbWIGESx (ORCPT ); Thu, 7 Sep 2006 00:18:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965294AbWIGESw (ORCPT ); Thu, 7 Sep 2006 00:18:52 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:58757 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S964883AbWIGESw (ORCPT ); Thu, 7 Sep 2006 00:18:52 -0400 Message-ID: <44FF9DA8.10007@garzik.org> Date: Thu, 07 Sep 2006 00:18:48 -0400 From: Jeff Garzik User-Agent: Thunderbird 1.5.0.5 (X11/20060808) MIME-Version: 1.0 To: Shaohua Li CC: lkml , Andrew Morton , Tigran Aivazian Subject: Re: [PATCH] x86 microcode: don't check the size References: <1157597227.2782.55.camel@sli10-desk.sh.intel.com> In-Reply-To: <1157597227.2782.55.camel@sli10-desk.sh.intel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.3 (----) X-Spam-Report: SpamAssassin version 3.1.3 on srv5.dvmed.net summary: Content analysis details: (-4.3 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 749 Lines: 21 Shaohua Li wrote: > IA32 manual says if micorcode update's size is 0, then the size is > default size (2048 bytes). But this doesn't suggest all microcode > update's size should be above 2048 bytes to me. We actually had a > microcode update whose size is 1024 bytes. The patch just removed the > check. > > Signed-off-by: Shaohua Li Why not explicitly check for zero, rather than removing the questionable less-than test? The default size logic hasn't disappeared... Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/