Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Song Liu <songliubraving@fb.com>
To:     Namhyung Kim <namhyung@kernel.org>
CC:     linux-kernel <linux-kernel@vger.kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Jiri Olsa <jolsa@redhat.com>,
        "Kernel Team" <Kernel-team@fb.com>
Subject: Re: [PATCH v6 3/4] perf-stat: enable counting events for BPF programs
Thread-Topic: [PATCH v6 3/4] perf-stat: enable counting events for BPF
 programs
Thread-Index: AQHW3UCo6hW/vcfUc06GxX5agiqE96oNrCiAgACuXACAAAOdAA==
Date:   Tue, 29 Dec 2020 17:59:14 +0000
Message-ID: <0D527E3F-7390-4D54-8E6B-FCCD09BA8901@fb.com>
References: <20201228174054.907740-1-songliubraving@fb.com>
 <20201228174054.907740-4-songliubraving@fb.com>
 <CAM9d7ciBsQqp2C5jWnitaK1Lttrq46NMcTLwE70oaqm82T88+Q@mail.gmail.com>
 <B5D51BCD-C9FA-458D-B8C9-345BC2AD16E6@fb.com>
In-Reply-To: <B5D51BCD-C9FA-458D-B8C9-345BC2AD16E6@fb.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <7B32630DB6C6E1459D7C44B7592CA59A@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 9fa6f22f-c479-4069-b7f4-08d8ac23745e
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Dec 2020 17:59:14.8143
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: pQnAkMBYMWP3BcjLE2YekzgdZpdnn3Q1+ay6Jl0NglAs5rLMaPC8cp2Na+kAOdHHeELcgYWrLUye5Q6xPs/rAg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB4120
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343,18.0.737
 definitions=2020-12-29_13:2020-12-28,2020-12-29 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 malwarescore=0
 spamscore=0 priorityscore=1501 clxscore=1015 impostorscore=0
 suspectscore=0 mlxscore=0 bulkscore=0 phishscore=0 mlxlogscore=999
 lowpriorityscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2009150000 definitions=main-2012290115
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Dec 29, 2020, at 9:46 AM, Song Liu <songliubraving@fb.com> wrote:
>=20
>>>=20

[...]

>=20
> [...]
>=20
>>> +static inline bool target__has_bpf(struct target *target)
>>> +{
>>> +       return target->bpf_str;
>>> +}
>>> +
>>> static inline bool target__none(struct target *target)
>>> {
>>>       return !target__has_task(target) && !target__has_cpu(target);
>>=20
>> Shouldn't it have && !target__has_bpf() too?

Actually, we don't need target__has_bpf() here. As -b requires setting up c=
ounters
system wide (in setup_system_wide()). If we add target__has_bpf() here, we =
will
need something like below, which I think it not necessary.=20

diff --git i/tools/perf/builtin-stat.c w/tools/perf/builtin-stat.c
index 09bffb3fbcdd4..853cec040191b 100644
--- i/tools/perf/builtin-stat.c
+++ w/tools/perf/builtin-stat.c
@@ -2081,7 +2081,7 @@ static void setup_system_wide(int forks)
         *   - there is workload specified but all requested
         *     events are system wide events
         */
-       if (!target__none(&target))
+       if (!target__none(&target) && !target__has_bpf(&target))
                return;

        if (!forks)
diff --git i/tools/perf/util/target.h w/tools/perf/util/target.h
index f132c6c2eef81..295fb11f4daff 100644
--- i/tools/perf/util/target.h
+++ w/tools/perf/util/target.h
@@ -71,7 +71,8 @@ static inline bool target__has_bpf(struct target *target)

 static inline bool target__none(struct target *target)
 {
-       return !target__has_task(target) && !target__has_cpu(target);
+       return !target__has_task(target) && !target__has_cpu(target) &&
+               !target__has_bpf(target);
 }

 static inline bool target__has_per_thread(struct target *target)