Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <cbfba11f00850e610d0a6ca1e0da2ead977f1574.camel@dylanvanassche.be>
Subject: Re: [PATCH v2] leds: gpio: Set max brightness to 1
From:   Dylan Van Assche <me@dylanvanassche.be>
To:     Pavel Machek <pavel@ucw.cz>
Cc:     dmurphy@ti.com, linux-leds@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Tue, 29 Dec 2020 19:09:11 +0100
In-Reply-To: <20201229160450.GA9564@duo.ucw.cz>
References: <20201229142440.31916-1-me@dylanvanassche.be>
         <20201229160450.GA9564@duo.ucw.cz>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi!

Thanks for the feedback!
Indeed, this can be even more simplified with your suggestion.
I will send a new version of the patch soon.

Happy holidays!

Kind regards,
Dylan Van Assche

On Tue, 2020-12-29 at 17:04 +0100, Pavel Machek wrote:
> Hi!
> 
> > GPIO LEDs only know 2 states: ON or OFF and do not have PWM
> > capabilities.
> > However, the max brightness is reported as 255.
> > 
> > This patch sets the max brightness value of a GPIO controlled LED
> > to 1.
> > 
> > Tested on my PinePhone 1.2.
> > 
> > Signed-off-by: Dylan Van Assche <me@dylanvanassche.be>
> > ---
> > v2 drops an obsolete change in include/linux/leds.h
> 
> I thought that one looked odd.
> 
> > +++ b/drivers/leds/leds-gpio.c
> > @@ -96,7 +96,8 @@ static int create_gpio_led(const struct gpio_led
> > *template,
> >  	} else {
> >  		state = (template->default_state ==
> > LEDS_GPIO_DEFSTATE_ON);
> >  	}
> > -	led_dat->cdev.brightness = state ? LED_FULL : LED_OFF;
> > +	led_dat->cdev.brightness = state ? LED_ON : LED_OFF;
> > +	led_dat->cdev.max_brightness = LED_ON;
> 
> Would simpler version work:
> 
> > +	led_dat->cdev.brightness = state;
> > +	led_dat->cdev.max_brightness = 1;
> 
> ? Easier to understand... I'd prefer that version unless it causes
> warnings or something.
> 
> 								Pavel