Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201226072717.32001-1-dinghao.liu@zju.edu.cn>
In-Reply-To: <20201226072717.32001-1-dinghao.liu@zju.edu.cn>
From:   Oded Gabbay <oded.gabbay@gmail.com>
Date:   Tue, 29 Dec 2020 23:30:20 +0200
Message-ID: <CAFCwf13k0Si+NvF2NXNEhXL2oG+ARtv=rCcXtuOwwNm7wH1AJg@mail.gmail.com>
Subject: Re: [PATCH] habanalabs: Fix memleak in hl_device_reset
To:     Dinghao Liu <dinghao.liu@zju.edu.cn>
Cc:     kjlu@umn.edu, Oded Gabbay <ogabbay@kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Tomer Tayar <ttayar@habana.ai>,
        Omer Shpigelman <oshpigelman@habana.ai>,
        Ofir Bitton <obitton@habana.ai>,
        Moti Haimovski <mhaimovski@habana.ai>,
        "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Dec 26, 2020 at 9:32 AM Dinghao Liu <dinghao.liu@zju.edu.cn> wrote:
>
> When kzalloc() fails, we should execute hl_mmu_fini()
> to release the MMU module. It's the same when
> hl_ctx_init() fails.
>
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> ---
>  drivers/misc/habanalabs/common/device.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/misc/habanalabs/common/device.c b/drivers/misc/habanalabs/common/device.c
> index 5871162a8442..e5028890ead1 100644
> --- a/drivers/misc/habanalabs/common/device.c
> +++ b/drivers/misc/habanalabs/common/device.c
> @@ -1092,6 +1092,7 @@ int hl_device_reset(struct hl_device *hdev, bool hard_reset,
>                                                 GFP_KERNEL);
>                 if (!hdev->kernel_ctx) {
>                         rc = -ENOMEM;
> +                       hl_mmu_fini(hdev);
>                         goto out_err;
>                 }
>
> @@ -1103,6 +1104,7 @@ int hl_device_reset(struct hl_device *hdev, bool hard_reset,
>                                 "failed to init kernel ctx in hard reset\n");
>                         kfree(hdev->kernel_ctx);
>                         hdev->kernel_ctx = NULL;
> +                       hl_mmu_fini(hdev);
>                         goto out_err;
>                 }
>         }
> --
> 2.17.1
>
Thanks!

This patch is:
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>

Applied to -fixes
Oded